Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issue 309463003: Revert of Updating calls to offscreen buffers to use a size of (0,0) when they do not require (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, jam, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, ccameron
Visibility:
Public.

Description

Revert of Updating calls to offscreen buffers to use a size of (0,0) when they do not require an actual buffer (https://codereview.chromium.org/293293002/) Reason for revert: This CL broke VMTest on ChromiumOS bot: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/21999 http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/21999/steps/VMTest%20%28attempt%201%29/logs/stdio See http://crbug.com/378430 Original issue's description: > Updating calls to offscreen buffers to use a size of (0,0) when they do not require an actual buffer > > These updates would enable the surfaceless context extension where available. > > BUG=377497 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273225 TBR=kbr@chromium.org,dnicoara@chromium.org NOTREECHECKS=true NOTRY=true BUG=377497, 378430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M content/common/gpu/gpu_channel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_egl.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_osmesa.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Created Revert of Updating calls to offscreen buffers to use a size of (0,0) when ...
6 years, 6 months ago (2014-05-29 10:16:13 UTC) #1
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-05-29 10:16:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/309463003/1
6 years, 6 months ago (2014-05-29 10:18:47 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 10:20:53 UTC) #4
Message was sent while issue was closed.
Change committed as 273467

Powered by Google App Engine
This is Rietveld 408576698