content/browser/service_worker/service_worker_storage.cc - Issue 309453002: ServiceWorker: Rename 'pending version' to 'installing' or 'waiting'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.cc

Issue 309453002: ServiceWorker: Rename 'pending version' to 'installing' or 'waiting' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_storage.cc

diff --git a/content/browser/service_worker/service_worker_storage.cc b/content/browser/service_worker/service_worker_storage.cc

index af7908a34ca7588eeee6aa462af9a80b989733cb..9763a260f55f50e00675dd9c174b1da6a0e362ff 100644

--- a/content/browser/service_worker/service_worker_storage.cc

+++ b/content/browser/service_worker/service_worker_storage.cc

@@ -660,7 +660,7 @@ ServiceWorkerStorage::GetOrCreateRegistration(

if (version->status() == ServiceWorkerVersion::ACTIVE)

registration->set_active_version(version);

else if (version->status() == ServiceWorkerVersion::INSTALLED)

- registration->set_pending_version(version);

+ registration->set_waiting_version(version);

else

NOTREACHED();

// TODO(michaeln): Hmmm, what if DeleteReg was invoked after