content/browser/service_worker/service_worker_registration_unittest.cc - Issue 309453002: ServiceWorker: Rename 'pending version' to 'installing' or 'waiting'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 309453002: ServiceWorker: Rename 'pending version' to 'installing' or 'waiting' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_register_job.cc ('K') | « content/browser/service_worker/service_worker_registration.cc ('k') | content/browser/service_worker/service_worker_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index f85967a94cf0dc2261194f9b4b61a77c2557f9e8..ccce641752630200efd805e6bf96155f83ae86ad 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -63,9 +63,9 @@ TEST_F(ServiceWorkerRegistrationTest, ActivatePending) {

scoped_refptr<ServiceWorkerVersion> version_2 =

new ServiceWorkerVersion(registration, version_2_id, context_ptr_);

- registration->set_pending_version(version_2);

+ registration->set_waiting_version(version_2);

- registration->ActivatePendingVersion();

+ registration->ActivateWaitingVersion();

DCHECK_EQ(version_2, registration->active_version());

DCHECK(version_1->HasOneRef());

version_1 = NULL;