Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309413002: Revert 274558 "Move some extensions renderer resources to extens..." (Closed)

Created:
6 years, 6 months ago by Marijn Kruisselbrink
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 274558 "Move some extensions renderer resources to extens..." This broke various builds (http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/54738/steps/runhooks/logs/stdio for example) since chrome_renderer.gypi (and maybe other files) still have refernces to the old location of these resources. > Move some extensions renderer resources to extensions_renderer_resources.grd. > > This breaks the remaining dependency from src/extensions to chrome resources files. > > BUG=368334 > > Review URL: https://codereview.chromium.org/307833002 TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4206 lines) Patch
M trunk/src/apps/shell/app_shell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_repack_resources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/json_schema_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/messaging_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/safe_builtins_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/app_runtime_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/binding.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/context_menus_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/entry_id_manager.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/event.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/extension_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/greasemonkey_api.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/i18n_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/image_util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/json_schema.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/last_error.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/messaging.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/messaging_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/permissions_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/platform_app.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/platform_app.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/runtime_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/schema_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/send_request.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/set_icon.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/storage_area.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/test_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/uncaught_exception_handler.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/unload_event.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/renderer/resources/extensions/utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/renderer/resources/renderer_resources.grd View 5 chunks +27 lines, -0 lines 0 comments Download
M trunk/src/extensions/DEPS View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/extensions/extensions_resources.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/extensions/renderer/resources/app_runtime_custom_bindings.js View 1 chunk +0 lines, -56 lines 0 comments Download
D trunk/src/extensions/renderer/resources/binding.js View 1 chunk +0 lines, -434 lines 0 comments Download
D trunk/src/extensions/renderer/resources/context_menus_custom_bindings.js View 1 chunk +0 lines, -101 lines 0 comments Download
D trunk/src/extensions/renderer/resources/entry_id_manager.js View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/extensions/renderer/resources/event.js View 1 chunk +0 lines, -528 lines 0 comments Download
D trunk/src/extensions/renderer/resources/extension_custom_bindings.js View 1 chunk +0 lines, -113 lines 0 comments Download
D trunk/src/extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/src/extensions/renderer/resources/greasemonkey_api.js View 1 chunk +0 lines, -82 lines 0 comments Download
D trunk/src/extensions/renderer/resources/i18n_custom_bindings.js View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/extensions/renderer/resources/image_util.js View 1 chunk +0 lines, -82 lines 0 comments Download
D trunk/src/extensions/renderer/resources/json_schema.js View 1 chunk +0 lines, -525 lines 0 comments Download
D trunk/src/extensions/renderer/resources/last_error.js View 1 chunk +0 lines, -124 lines 0 comments Download
D trunk/src/extensions/renderer/resources/messaging.js View 1 chunk +0 lines, -386 lines 0 comments Download
D trunk/src/extensions/renderer/resources/messaging_utils.js View 1 chunk +0 lines, -53 lines 0 comments Download
D trunk/src/extensions/renderer/resources/permissions_custom_bindings.js View 1 chunk +0 lines, -97 lines 0 comments Download
D trunk/src/extensions/renderer/resources/platform_app.css View 1 chunk +0 lines, -35 lines 0 comments Download
D trunk/src/extensions/renderer/resources/platform_app.js View 1 chunk +0 lines, -207 lines 0 comments Download
D trunk/src/extensions/renderer/resources/runtime_custom_bindings.js View 1 chunk +0 lines, -205 lines 0 comments Download
D trunk/src/extensions/renderer/resources/schema_utils.js View 1 chunk +0 lines, -156 lines 0 comments Download
D trunk/src/extensions/renderer/resources/send_request.js View 1 chunk +0 lines, -178 lines 0 comments Download
D trunk/src/extensions/renderer/resources/set_icon.js View 1 chunk +0 lines, -131 lines 0 comments Download
D trunk/src/extensions/renderer/resources/storage_area.js View 1 chunk +0 lines, -40 lines 0 comments Download
D trunk/src/extensions/renderer/resources/test_custom_bindings.js View 1 chunk +0 lines, -353 lines 0 comments Download
D trunk/src/extensions/renderer/resources/uncaught_exception_handler.js View 1 chunk +0 lines, -21 lines 0 comments Download
D trunk/src/extensions/renderer/resources/unload_event.js View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/extensions/renderer/resources/utils.js View 1 chunk +0 lines, -127 lines 0 comments Download
M trunk/src/extensions/renderer/script_injection.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/gritsettings/resource_ids View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Marijn Kruisselbrink
6 years, 6 months ago (2014-06-03 17:39:24 UTC) #1
Marijn Kruisselbrink
6 years, 6 months ago (2014-06-03 17:39:37 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r274565.

Powered by Google App Engine
This is Rietveld 408576698