Move some extensions renderer resources to extensions_renderer_resources.grd.

Move some extensions renderer resources to extensions_renderer_resources.grd.

This breaks the remaining dependency from src/extensions to chrome resources files.

BUG=368334
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274558

[Yoyo Zhou, 2014-05-29 02:29:05]

rockot: I moved the remaining resources in dispatcher.cc. (I don't know exactly
how you chose some of them to move to chrome_extensions_dispatcher_delegate.cc
instead - some of those, we may eventually need in extensions/ again...)

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
File chrome/renderer/resources/renderer_resources.grd (right):

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
chrome/renderer/resources/renderer_resources.grd:3: without changes to the
corresponding grd file. fb9 -->
jam or kalman: Do you know if this is still true? I notice that this line hasn't
changed in many years.

[not at google - send to devlin, 2014-05-29 14:53:23]

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
File chrome/renderer/resources/renderer_resources.grd (right):

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
chrome/renderer/resources/renderer_resources.grd:3: without changes to the
corresponding grd file. fb9 -->
On 2014/05/29 02:29:06, Yoyo Zhou wrote:
> jam or kalman: Do you know if this is still true? I notice that this line
hasn't
> changed in many years.

I don't know, though I've often thought the same thing; I think it hasn't been
needed over my entire Chrome tenure?

So, I eagerly await the answer to this question.

[Ken Rockot(use gerrit already), 2014-05-29 15:33:42]

On 2014/05/29 02:29:05, Yoyo Zhou wrote:
> rockot: I moved the remaining resources in dispatcher.cc. (I don't know
exactly
> how you chose some of them to move to chrome_extensions_dispatcher_delegate.cc
> instead - some of those, we may eventually need in extensions/ again...)
> 

LGTM for the general move, deferring to jam for the other question.

As for what moved and what didn't, I moved anything which was required to bring
up an app, and I tried to move anything else that should eventually live in
//extensions and didn't drag gnarly dependencies along with it.

[jam, 2014-05-29 17:32:55]

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
File chrome/renderer/resources/renderer_resources.grd (right):

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
chrome/renderer/resources/renderer_resources.grd:3: without changes to the
corresponding grd file. fb9 -->
On 2014/05/29 14:53:24, kalman wrote:
> On 2014/05/29 02:29:06, Yoyo Zhou wrote:
> > jam or kalman: Do you know if this is still true? I notice that this line
> hasn't
> > changed in many years.
> 
> I don't know, though I've often thought the same thing; I think it hasn't been
> needed over my entire Chrome tenure?
> 
> So, I eagerly await the answer to this question.

I don't know; I suggest asking folks who review this file often (not sure who
off the top of my head)

[Yoyo Zhou, 2014-05-29 17:48:15]

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
File chrome/renderer/resources/renderer_resources.grd (right):

https://chromiumcodereview.appspot.com/307833002/diff/1/chrome/renderer/resou...
chrome/renderer/resources/renderer_resources.grd:3: without changes to the
corresponding grd file. fb9 -->
On 2014/05/29 17:32:55, jam wrote:
> On 2014/05/29 14:53:24, kalman wrote:
> > On 2014/05/29 02:29:06, Yoyo Zhou wrote:
> > > jam or kalman: Do you know if this is still true? I notice that this line
> > hasn't
> > > changed in many years.
> > 
> > I don't know, though I've often thought the same thing; I think it hasn't
been
> > needed over my entire Chrome tenure?
> > 
> > So, I eagerly await the answer to this question.
> 
> I don't know; I suggest asking folks who review this file often (not sure who
> off the top of my head)

I talked to Finnur who thinks it may no longer be necessary, and I just verified
on my local build that resources changes do get picked up. So I'll delete this.

[Yoyo Zhou, 2014-05-29 17:51:13]

jam, would you like to review for OWNERS for
chrome/renderer/resources/renderer_resources.grd?

[Yoyo Zhou, 2014-05-30 01:00:20]

On 2014/05/29 17:51:13, Yoyo Zhou wrote:
> jam, would you like to review for OWNERS for
> chrome/renderer/resources/renderer_resources.grd?

I can also TBR if you prefer; it's not that interesting.

[jam, 2014-05-30 17:11:00]

On 2014/05/30 01:00:20, Yoyo Zhou wrote:
> On 2014/05/29 17:51:13, Yoyo Zhou wrote:
> > jam, would you like to review for OWNERS for
> > chrome/renderer/resources/renderer_resources.grd?
> 
> I can also TBR if you prefer; it's not that interesting.

lgtm, and yes feel free to tbr this in the future

[jam, 2014-05-30 17:11:00]

On 2014/05/30 01:00:20, Yoyo Zhou wrote:
> On 2014/05/29 17:51:13, Yoyo Zhou wrote:
> > jam, would you like to review for OWNERS for
> > chrome/renderer/resources/renderer_resources.grd?
> 
> I can also TBR if you prefer; it's not that interesting.

lgtm, and yes feel free to tbr this in the future

[Yoyo Zhou, 2014-05-30 19:06:51]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-05-30 19:08:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/307833002/40001

[commit-bot: I haz the power, 2014-05-31 00:09:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Yoyo Zhou, 2014-05-31 00:12:31]

The CQ bit was unchecked by yoz@chromium.org

[commit-bot: I haz the power, 2014-05-31 00:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 00:18:35]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Yoyo Zhou, 2014-05-31 01:53:07]

I missed one (greasemonkey API that's used in
extensions/renderer/script_injection.cc).

[Yoyo Zhou, 2014-05-31 01:53:14]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-05-31 01:53:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/307833002/60001

[commit-bot: I haz the power, 2014-05-31 05:21:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-31 05:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 05:23:13]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Yoyo Zhou, 2014-06-03 00:47:46]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-06-03 00:48:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/307833002/80001

[commit-bot: I haz the power, 2014-06-03 04:48:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 06:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 06:16:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Yoyo Zhou, 2014-06-03 16:35:27]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-06-03 16:36:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/307833002/80001

[commit-bot: I haz the power, 2014-06-03 17:15:56]

Change committed as 274558