Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issue 309303002: Update textinput_helper.js to support subpixel coordinates (Closed)

Created:
6 years, 6 months ago by eae
Modified:
6 years, 6 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update textinput_helper.js to support subpixel coordinates Update the textinput_helper.js text helper to support subpixel precision for element coordinates. R=nona@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274594

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/test/data/textinput/textinput_helper.js View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eae
6 years, 6 months ago (2014-06-03 12:28:10 UTC) #1
Seigo Nonaka
lgtm
6 years, 6 months ago (2014-06-03 12:45:49 UTC) #2
eae
Thanks!
6 years, 6 months ago (2014-06-03 12:46:37 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-03 16:01:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/309303002/20001
6 years, 6 months ago (2014-06-03 16:02:24 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:43:12 UTC) #6
Message was sent while issue was closed.
Change committed as 274594

Powered by Google App Engine
This is Rietveld 408576698