Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 309273002: Explicitly shutting down tabs and server at end of apprtc test. (Closed)

Created:
6 years, 6 months ago by phoglund_chromium
Modified:
6 years, 6 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Explicitly shutting down tabs and server at end of apprtc test. This is another attempt to try to figure out where we are really hanging when this test hangs on the Win7 WebRTC bot. no-try to bypass flaky win_rel bot. TBR=grunell@chromium.org BUG=373252 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
phoglund_chromium
6 years, 6 months ago (2014-06-03 10:16:26 UTC) #1
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 6 months ago (2014-06-03 10:16:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/309273002/1
6 years, 6 months ago (2014-06-03 10:20:58 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 14:36:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 17:59:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/22999)
6 years, 6 months ago (2014-06-03 17:59:30 UTC) #6
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 6 months ago (2014-06-03 18:20:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/309273002/1
6 years, 6 months ago (2014-06-03 18:21:31 UTC) #8
commit-bot: I haz the power
Change committed as 274574
6 years, 6 months ago (2014-06-03 18:23:12 UTC) #9
Henrik Grunell
6 years, 6 months ago (2014-06-04 08:46:49 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698