Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6178)

Unified Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 309273002: Explicitly shutting down tabs and server at end of apprtc test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
index 20ae8c750c57ad083e9cba38a1a5e5f71d294645..8023a5b3166a6364f0df49b1d7ba0d62a9143682 100644
--- a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
@@ -220,8 +220,10 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
return false;
}
- private:
+ // TODO(phoglund): should be private again after win-only experiments.
base::ProcessHandle dev_appserver_;
+
+ private:
base::ProcessHandle firefox_;
};
@@ -284,6 +286,16 @@ IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, MANUAL_WorksOnApprtc) {
LOG(INFO) << "Slept a bit; " << timer.Elapsed().InSeconds()
<< " seconds elapsed.";
+
+#if defined (OS_WIN)
+ // TODO(phoglund): experimenting with explicitly tearing down here.
+ chrome::CloseWebContents(browser(), left_tab, false);
+ LOG(INFO) << "Closed left tab.";
+ chrome::CloseWebContents(browser(), right_tab, false);
+ LOG(INFO) << "Closed right tab.";
+
+ base::KillProcess(dev_appserver_, 0, false);
+#endif
}
#if defined(OS_LINUX)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698