Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 309223002: Add logging to help diagnose reason for ASan LSan flakiness. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add logging to help diagnose reason for ASan LSan flakiness. The test PlatformAppBrowserTest.AppWindowAdjustBounds... is flaky on the Linux ChromeOS ASan LSan bot. This adds some temporary loggin' to get some information on where it is hanging. BUG=377754 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benwells
6 years, 6 months ago (2014-06-03 05:54:25 UTC) #1
calamity
lgtm. CL description should either say "logging" or "loggin'" on 2nd line.
6 years, 6 months ago (2014-06-03 06:30:59 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-03 06:33:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/309223002/1
6 years, 6 months ago (2014-06-03 06:34:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 08:12:45 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 13:18:01 UTC) #6
Message was sent while issue was closed.
Change committed as 274503

Powered by Google App Engine
This is Rietveld 408576698