Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8981)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 309223002: Add logging to help diagnose reason for ASan LSan flakiness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 604161fb85a7f2dfee52b95ea6a1ed72704e2d1c..44e280485527da4cc2b1a380182b2e48e65b4552 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -748,9 +748,14 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWindowRestoreState) {
IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
AppWindowAdjustBoundsToBeVisibleOnScreen) {
+ // TODO(benwells): Remove this logging once flakiness has been observed.
+ // See http://crbug.com/377754.
+ LOG(WARNING) << "Loading minimal app";
const Extension* extension = LoadAndLaunchPlatformApp("minimal");
+ LOG(WARNING) << "Creating window";
AppWindow* window = CreateAppWindow(extension);
+ LOG(WARNING) << "Performing tests";
// The screen bounds didn't change, the cached bounds didn't need to adjust.
gfx::Rect cached_bounds(80, 100, 400, 400);
gfx::Rect cached_screen_bounds(0, 0, 1600, 900);
@@ -818,6 +823,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
gfx::Size(900, 900),
&bounds);
EXPECT_EQ(bounds, gfx::Rect(0, 0, 900, 900));
+ LOG(WARNING) << "Tests complete";
}
namespace {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698