Navigation transitions: Added "addStyleSheetByURL" function to insert stylesheet links.

Navigation transitions: Added "addStyleSheetByURL" function to insert stylesheet links. 

If transition-entering-stylesheet is defined in the response headers for the incoming document, they're parsed out, passed to the TransitionPageHelper in the embedder, and are applied to the page via addStyleSheetByUrl at the appropriate time in the transition. 

This is the chrome side of the CL, blink side here: https://codereview.chromium.org/285623003/ 

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# 
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 
BUG=370696
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278856

[shatch, 2014-06-02 21:55:08]

Hi guys, ptal

bulach
* content/browser/android/content_view_core_impl.cc
* content/browser/android/content_view_core_impl.h
*
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

dcheng
* content/common/frame_messages.h

jamesr
* content/renderer/render_frame_impl.cc
* content/renderer/render_frame_impl.h

[dcheng, 2014-06-02 22:03:08]

frame_messages.h LGTM

...though IMO, the Blink API function should move to its own section ( //
Navigation transitions --------------- ) instead of just being dumped into the
middle of the selection helpers.

[shatch, 2014-06-02 23:51:41]

On 2014/06/02 22:03:08, dcheng wrote:
> frame_messages.h LGTM
> 
> ...though IMO, the Blink API function should move to its own section ( //
> Navigation transitions --------------- ) instead of just being dumped into the
> middle of the selection helpers.

Thanks! Moved it into its own section.

[dcheng, 2014-06-02 23:57:21]

On 2014/06/02 23:51:41, shatch wrote:
> On 2014/06/02 22:03:08, dcheng wrote:
> > frame_messages.h LGTM
> > 
> > ...though IMO, the Blink API function should move to its own section ( //
> > Navigation transitions --------------- ) instead of just being dumped into
the
> > middle of the selection helpers.
> 
> Thanks! Moved it into its own section.

I actually meant the changes in WebFrame.h =)

As far as I know, there's no such convention for IPC messages so delineating it
with a block comment here is probably unnecessary and potentially confusing. I
would just update the comment to specifically mention that it's to support
navigation transitions.

[bulach, 2014-06-03 10:51:55]

lgtm for android/ files, but please wait for sami as well. thanks!

tiny nit below.

https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
content/browser/android/content_view_core_impl.cc:1210:
web_contents_->GetMainFrame()->GetRoutingID(),
nit: indent +2 here and below since it's a continuation

[Sami, 2014-06-03 15:07:29]

content/browser/android lgtm % style nit.

https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
content/browser/android/content_view_core_impl.cc:1208: if (web_contents_)
Should use braces here since the body is a multi-line statement. Alternatively
you could just early out if !web_contents.

[shatch, 2014-06-05 20:45:06]

On 2014/06/03 15:07:29, Sami wrote:
> content/browser/android lgtm % style nit.
> 
>
https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
> File content/browser/android/content_view_core_impl.cc (right):
> 
>
https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
> content/browser/android/content_view_core_impl.cc:1208: if (web_contents_)
> Should use braces here since the body is a multi-line statement. Alternatively
> you could just early out if !web_contents.

Nits addressed, removing jamesr at his request, adding darin since you're
familiar with the navigation transitions. ptal!

darin
* content/renderer/render_frame_impl.cc
* content/renderer/render_frame_impl.h

[shatch, 2014-06-10 23:36:57]

On 2014/06/05 20:45:06, shatch wrote:
> On 2014/06/03 15:07:29, Sami wrote:
> > content/browser/android lgtm % style nit.
> > 
> >
>
https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
> > File content/browser/android/content_view_core_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
> > content/browser/android/content_view_core_impl.cc:1208: if (web_contents_)
> > Should use braces here since the body is a multi-line statement.
Alternatively
> > you could just early out if !web_contents.
> 
> Nits addressed, removing jamesr at his request, adding darin since you're
> familiar with the navigation transitions. ptal!
> 
> darin
> * content/renderer/render_frame_impl.cc
> * content/renderer/render_frame_impl.h

ping darin

[shatch, 2014-06-18 20:01:03]

On 2014/06/10 23:36:57, shatch wrote:
> On 2014/06/05 20:45:06, shatch wrote:
> > On 2014/06/03 15:07:29, Sami wrote:
> > > content/browser/android lgtm % style nit.
> > > 
> > >
> >
>
https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
> > > File content/browser/android/content_view_core_impl.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/309143002/diff/20001/content/browser/android/...
> > > content/browser/android/content_view_core_impl.cc:1208: if (web_contents_)
> > > Should use braces here since the body is a multi-line statement.
> Alternatively
> > > you could just early out if !web_contents.
> > 
> > Nits addressed, removing jamesr at his request, adding darin since you're
> > familiar with the navigation transitions. ptal!
> > 
> > darin
> > * content/renderer/render_frame_impl.cc
> > * content/renderer/render_frame_impl.h
> 
> ping darin

ping darin

[darin (slow to review), 2014-06-20 05:59:00]

LGTM

[shatch, 2014-06-20 16:39:53]

The CQ bit was checked by simonhatch@chromium.org

[commit-bot: I haz the power, 2014-06-20 16:40:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonhatch@chromium.org/309143002/40001

[commit-bot: I haz the power, 2014-06-20 17:14:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/19602)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/23234)

[commit-bot: I haz the power, 2014-06-20 17:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 17:20:48]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/19621)

[shatch, 2014-06-20 17:31:31]

The CQ bit was checked by simonhatch@chromium.org

[commit-bot: I haz the power, 2014-06-20 17:33:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonhatch@chromium.org/309143002/60001

[shatch, 2014-06-20 18:53:58]

The CQ bit was checked by simonhatch@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:03:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonhatch@chromium.org/309143002/80001

[commit-bot: I haz the power, 2014-06-20 23:23:47]

Change committed as 278856