Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 285623003: Navigation transitions: Added "addStyleSheetByURL" function to insert stylesheet links. (Closed)

Created:
6 years, 7 months ago by shatch
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Navigation transitions: Added "addStyleSheetByURL" function to insert stylesheet links. If transition-entering-stylesheet is defined in the response headers for the incoming document, this stylesheet will be applied as the incoming document is shown. This is the blink side of the CL. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174470

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
shatch
Hi Adam, cutting up transitions change into bunch of cls, ptal.
6 years, 7 months ago (2014-05-14 18:11:59 UTC) #1
shatch
Hi Eric, since Adam is out, do you mind taking a look?
6 years, 7 months ago (2014-05-19 19:12:56 UTC) #2
eseidel
Is this just a convenience function? I would presume one could do this already by ...
6 years, 7 months ago (2014-05-20 23:03:42 UTC) #3
shatch
On 2014/05/20 23:03:42, eseidel wrote: > Is this just a convenience function? I would presume ...
6 years, 7 months ago (2014-05-20 23:10:39 UTC) #4
eseidel
lgtm :shrug:. I'm not sure this is worth pushing into the Blink API, but OK.
6 years, 7 months ago (2014-05-21 00:44:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/285623003/20001
6 years, 7 months ago (2014-05-21 00:44:53 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:30:30 UTC) #7
Message was sent while issue was closed.
Change committed as 174470

Powered by Google App Engine
This is Rietveld 408576698