chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc - Issue 308833002: [Mac] Password generation: Make "saved passwords" a hyperlink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 308833002: [Mac] Password generation: Make "saved passwords" a hyperlink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h » ('j') | chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

index d946711d78758bd168cc69f858252c4d2900a8f5..2f75c629f9f450bcb8b43d43a7195ed44d3ead1f 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

@@ -100,7 +100,7 @@ PasswordGenerationPopupControllerImpl::PasswordGenerationPopupControllerImpl(

}

PasswordGenerationPopupControllerImpl::~PasswordGenerationPopupControllerImpl()

- {}

+{}

Ilya Sherman 2014/05/30 19:44:22 This change doesn't seem relevant to the thrust of

Evan Stade 2014/05/30 22:50:59 FWIW clang format gives: PasswordGenerationPopupC

Ilya Sherman 2014/05/30 22:58:33 (As long as we're bikeshedding, the clang format f

Patrick Dubroy 2014/06/02 07:46:52 Done.

base::WeakPtr<PasswordGenerationPopupControllerImpl>

PasswordGenerationPopupControllerImpl::GetWeakPtr() {