[Mac] Password generation: Make "saved passwords" a hyperlink.

chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h"
 
 #include <math.h>
 
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
@@ skipping 82 matching lines @@
       l10n_util::GetStringUTF16(IDS_PASSWORD_GENERATION_PROMPT),
       '|',  // separator
       &pieces);
   DCHECK_EQ(3u, pieces.size());
   link_range_ = gfx::Range(pieces[0].size(),
                            pieces[0].size() + pieces[1].size());
   help_text_ = JoinString(pieces, base::string16());
 }
 
 PasswordGenerationPopupControllerImpl::~PasswordGenerationPopupControllerImpl()
-  {}
+{}

[Ilya Sherman, 2014/05/30 19:44:22]

This change doesn't seem relevant to the thrust of your CL.  Please revert it. 
Then, you get the bonus of needing fewer reviewers :)

[Evan Stade, 2014/05/30 22:50:59]

FWIW clang format gives:

PasswordGenerationPopupControllerImpl::
    ~PasswordGenerationPopupControllerImpl() {
}

which is certainly novel.

[Ilya Sherman, 2014/05/30 22:58:33]

(As long as we're bikeshedding, the clang format formatting is consistent with
what I'd expect.)

[Patrick Dubroy, 2014/06/02 07:46:52]

Done.

 
 base::WeakPtr<PasswordGenerationPopupControllerImpl>
 PasswordGenerationPopupControllerImpl::GetWeakPtr() {
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 bool PasswordGenerationPopupControllerImpl::HandleKeyPressEvent(
     const content::NativeWebKeyboardEvent& event) {
   switch (event.windowsKeyCode) {
     case ui::VKEY_UP:
@@ skipping 234 matching lines @@
 
 const base::string16& PasswordGenerationPopupControllerImpl::HelpText() {
   return help_text_;
 }
 
 const gfx::Range& PasswordGenerationPopupControllerImpl::HelpTextLinkRange() {
   return link_range_;
 }
 
 }  // namespace autofill