Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 308793010: Inline Array.shift() fast path instead of using a code stub. (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer
Modified:
6 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Inline Array.shift() fast path instead of using a code stub. TEST=mjsunit/array-shift,mjsunit/array-shift2,mjsunit/array-shift3 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21592

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -429 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +87 lines, -4 lines 2 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -47 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Simplifies code and gives small performance improvement for Array.shift() in loops (i.e. Havlak). PTAL
6 years, 6 months ago (2014-06-02 06:36:50 UTC) #1
Yang
lgtm with comment. https://codereview.chromium.org/308793010/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/308793010/diff/1/src/hydrogen.cc#newcode7951 src/hydrogen.cc:7951: { Could we have a BuildArrayShift ...
6 years, 6 months ago (2014-06-02 06:57:01 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/308793010/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/308793010/diff/1/src/hydrogen.cc#newcode7951 src/hydrogen.cc:7951: { As discussed offline: Leaving it here for consistency ...
6 years, 6 months ago (2014-06-02 07:02:11 UTC) #3
Benedikt Meurer
6 years, 6 months ago (2014-06-02 07:02:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698