Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: src/hydrogen-instructions.h

Issue 308793010: Inline Array.shift() fast path instead of using a code stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index ef88d2b9a5082538bfec73368aa6c4e5158bf1af..d413af0c15455c3ea2f82a2f61938fd5526f5c31 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -51,7 +51,6 @@ class LChunkBuilder;
V(ArgumentsElements) \
V(ArgumentsLength) \
V(ArgumentsObject) \
- V(ArrayShift) \
V(Bitwise) \
V(BlockEntry) \
V(BoundsCheck) \
@@ -7090,52 +7089,6 @@ class HTransitionElementsKind V8_FINAL : public HTemplateInstruction<2> {
};
-class HArrayShift V8_FINAL : public HTemplateInstruction<2> {
- public:
- static HArrayShift* New(Zone* zone,
- HValue* context,
- HValue* object,
- ElementsKind kind) {
- return new(zone) HArrayShift(context, object, kind);
- }
-
- virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
- return Representation::Tagged();
- }
-
- HValue* context() const { return OperandAt(0); }
- HValue* object() const { return OperandAt(1); }
- ElementsKind kind() const { return kind_; }
-
- virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
-
- DECLARE_CONCRETE_INSTRUCTION(ArrayShift);
-
- protected:
- virtual bool DataEquals(HValue* other) V8_OVERRIDE {
- HArrayShift* that = HArrayShift::cast(other);
- return this->kind_ == that->kind_;
- }
-
- private:
- HArrayShift(HValue* context, HValue* object, ElementsKind kind)
- : kind_(kind) {
- SetOperandAt(0, context);
- SetOperandAt(1, object);
- SetChangesFlag(kArrayLengths);
- SetChangesFlag(kNewSpacePromotion);
- set_representation(Representation::Tagged());
- if (IsFastSmiOrObjectElementsKind(kind)) {
- SetChangesFlag(kArrayElements);
- } else {
- SetChangesFlag(kDoubleArrayElements);
- }
- }
-
- ElementsKind kind_;
-};
-
-
class HStringAdd V8_FINAL : public HBinaryOperation {
public:
static HInstruction* New(Zone* zone,
« src/hydrogen.cc ('K') | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698