Issue 308733002: Merge 268831 "Replicate FFmpeg's video frame allocation strategy."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308733002: Merge 268831 "Replicate FFmpeg's video frame allocation strategy." (Closed)

Created:
6 years, 6 months ago by DaleCurtis

Modified:
6 years, 6 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

Merge 268831 "Replicate FFmpeg's video frame allocation strategy." > Replicate FFmpeg's video frame allocation strategy. > > This should avoid accidental overreads and overwrites due to our > VideoFrame's not being as large as FFmpeg expects. > > BUG=368980 > TEST=new regression test > > Review URL: https://codereview.chromium.org/270193002 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273520

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -8 lines)			Patch
	M	media/ffmpeg/ffmpeg_regression_tests.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	media/filters/ffmpeg_video_decoder.cc	View		3 chunks	+18 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

DaleCurtis

6 years, 6 months ago (2014-05-29 18:04:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273520 (tree was closed).