Replicate FFmpeg's video frame allocation strategy.

Replicate FFmpeg's video frame allocation strategy.

This should avoid accidental overreads and overwrites due to our
VideoFrame's not being as large as FFmpeg expects.

BUG=368980
TEST=new regression test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268831

[DaleCurtis, 2014-05-06 21:31:39]

See here for more details:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg...

[scherkus (not reviewing), 2014-05-07 03:04:30]

lgtm w/ nits

https://codereview.chromium.org/270193002/diff/1/media/filters/ffmpeg_video_d...
File media/filters/ffmpeg_video_decoder.cc (right):

https://codereview.chromium.org/270193002/diff/1/media/filters/ffmpeg_video_d...
media/filters/ffmpeg_video_decoder.cc:76: if (ret < 0)
intentional change / cleanup?

https://codereview.chromium.org/270193002/diff/1/media/filters/ffmpeg_video_d...
media/filters/ffmpeg_video_decoder.cc:89: // following logic replicates FFMpeg's
allocation strategy to ensure buffers
nit: s/FFMpeg/FFmpeg/

[DaleCurtis, 2014-05-07 03:34:18]

Thanks for review.

https://codereview.chromium.org/270193002/diff/1/media/filters/ffmpeg_video_d...
File media/filters/ffmpeg_video_decoder.cc (right):

https://codereview.chromium.org/270193002/diff/1/media/filters/ffmpeg_video_d...
media/filters/ffmpeg_video_decoder.cc:76: if (ret < 0)
On 2014/05/07 03:04:31, scherkus wrote:
> intentional change / cleanup?

Yes, we don't use this type of expression regularly, so away it goes.

https://codereview.chromium.org/270193002/diff/1/media/filters/ffmpeg_video_d...
media/filters/ffmpeg_video_decoder.cc:89: // following logic replicates FFMpeg's
allocation strategy to ensure buffers
On 2014/05/07 03:04:31, scherkus wrote:
> nit: s/FFMpeg/FFmpeg/

Done.

[DaleCurtis, 2014-05-07 03:34:23]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-05-07 03:40:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/270193002/20001

[commit-bot: I haz the power, 2014-05-07 16:55:58]

Change committed as 268831