Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 308703009: Update comments about debugging on master. (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com, epoger, jvanverth1
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Update comments about debugging on master. Update the makefile to reference the correct location of config.mk. Committed: https://skia.googlesource.com/skia/+/b30aa62294733c8dda1b7bbfa4fe9df688513e84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M platform_tools/android/gyp_gen/makefile_writer.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scroggo
6 years, 6 months ago (2014-06-02 13:54:27 UTC) #1
djsollen
lgtm
6 years, 6 months ago (2014-06-02 14:13:06 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-02 14:13:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/308703009/1
6 years, 6 months ago (2014-06-02 14:14:08 UTC) #4
commit-bot: I haz the power
Change committed as b30aa62294733c8dda1b7bbfa4fe9df688513e84
6 years, 6 months ago (2014-06-02 14:19:21 UTC) #5
epoger
This CL broke http://108.170.220.102:10117/builders/Housekeeper-PerCommit/builds/1481
6 years, 6 months ago (2014-06-02 20:20:33 UTC) #6
scroggo
6 years, 6 months ago (2014-06-02 20:22:21 UTC) #7
Message was sent while issue was closed.
On 2014/06/02 20:20:33, epoger wrote:
> This CL broke
> http://108.170.220.102:10117/builders/Housekeeper-PerCommit/builds/1481

On it...

Powered by Google App Engine
This is Rietveld 408576698