Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 308703009: Update comments about debugging on master. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright 2014 Google Inc. 3 # Copyright 2014 Google Inc.
4 # 4 #
5 # Use of this source code is governed by a BSD-style license that can be 5 # Use of this source code is governed by a BSD-style license that can be
6 # found in the LICENSE file. 6 # found in the LICENSE file.
7 7
8 """ 8 """
9 Functions for creating an Android.mk from already created dictionaries. 9 Functions for creating an Android.mk from already created dictionaries.
10 """ 10 """
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 # using libskia must also be built with the debug version of the Skia headers. 91 # using libskia must also be built with the debug version of the Skia headers.
92 # There are a few scenarios where this comes into play: 92 # There are a few scenarios where this comes into play:
93 # 93 #
94 # (1) You're building debug code that depends on libskia. 94 # (1) You're building debug code that depends on libskia.
95 # (a) If libskia is built in release, then define SK_RELEASE when building 95 # (a) If libskia is built in release, then define SK_RELEASE when building
96 # your sources. 96 # your sources.
97 # (b) If libskia is built with debugging (see step 2), then no changes are 97 # (b) If libskia is built with debugging (see step 2), then no changes are
98 # needed since your sources and libskia have been built with SK_DEBUG. 98 # needed since your sources and libskia have been built with SK_DEBUG.
99 # (2) You're building libskia in debug mode. 99 # (2) You're building libskia in debug mode.
100 # (a) RECOMMENDED: You can build the entire system in debug mode. Do this by 100 # (a) RECOMMENDED: You can build the entire system in debug mode. Do this by
101 # updating your build/config.mk to include -DSK_DEBUG on the line that 101 # updating your build/core/config.mk to include -DSK_DEBUG on the line
102 # defines COMMON_GLOBAL_CFLAGS 102 # that defines COMMON_GLOBAL_CFLAGS
103 # (b) You can update all the users of libskia to define SK_DEBUG when they are 103 # (b) You can update all the users of libskia to define SK_DEBUG when they are
104 # building their sources. 104 # building their sources.
105 # 105 #
106 # NOTE: If neither SK_DEBUG or SK_RELEASE are defined then Skia checks NDEBUG to 106 # NOTE: If neither SK_DEBUG or SK_RELEASE are defined then Skia checks NDEBUG to
107 # determine which build type to use. 107 # determine which build type to use.
108 ############################################################################### 108 ###############################################################################
109 109
110 """ 110 """
111 ) 111 )
112 112
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 if data.condition: 224 if data.condition:
225 f.write('ifeq ($(%s), true)\n' % data.condition) 225 f.write('ifeq ($(%s), true)\n' % data.condition)
226 write_local_vars(f, data.vars_dict, True, data.name) 226 write_local_vars(f, data.vars_dict, True, data.name)
227 if data.condition: 227 if data.condition:
228 f.write('endif\n\n') 228 f.write('endif\n\n')
229 229
230 write_include_stlport(f) 230 write_include_stlport(f)
231 f.write('include $(BUILD_SHARED_LIBRARY)\n') 231 f.write('include $(BUILD_SHARED_LIBRARY)\n')
232 f.write(SKIA_TOOLS) 232 f.write(SKIA_TOOLS)
233 233
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698