Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 308703006: Revert 273648 "skia: Use medium filter quality in PaintSimplifier." (Closed)

Created:
6 years, 6 months ago by reveman
Modified:
6 years, 6 months ago
Reviewers:
reveman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273648 "skia: Use medium filter quality in PaintSimplifier." > skia: Use medium filter quality in PaintSimplifier. > > Preventing all bitmap filtering in the paint simplifier is a bad > idea as it's very cache unfriendly when down-sampling due to > requiring both the full size decoded image and the high/medium > quality image normally used to be cached for good performance. > > However, forcing medium quality filtering is worthwhile as it's > faster than high quality and still provides caching benefits. > > BUG= > > Review URL: https://codereview.chromium.org/305623008 Looks like this had a negative effect on memory usage. TBR=reveman@chromium.org BUG=379164 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M trunk/src/skia/ext/paint_simplifier.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reveman
6 years, 6 months ago (2014-05-30 21:48:18 UTC) #1
reveman
6 years, 6 months ago (2014-05-30 21:48:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273914 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698