skia: Use medium filter quality in PaintSimplifier.

skia: Use medium filter quality in PaintSimplifier.

Preventing all bitmap filtering in the paint simplifier is a bad
idea as it's very cache unfriendly when down-sampling due to
requiring both the full size decoded image and the high/medium
quality image normally used to be cached for good performance.

However, forcing medium quality filtering is worthwhile as it's
faster than high quality and still provides caching benefits.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273648

[reveman, 2014-05-28 22:51:57]

This seem to not only provide a bit of a performance improvement but also
reduces the discardable memory usage a significant bit on some web sites.
Probably because the mips used for medium quality filter can use less memory
than a high quality filtered image at the exact size and they can be reused when
the scale changes just a small amount.

Please take a look.

[reed1, 2014-05-29 12:15:40]

lgtm

Since this is (almost by definition) a policy function, perhaps a comment block
for this setting would help explain why we're picking what we're picking, for
the next maintainer.

[reed1, 2014-05-29 12:16:59]

https://codereview.chromium.org/305623008/diff/1/skia/ext/paint_simplifier.cc
File skia/ext/paint_simplifier.cc (right):

https://codereview.chromium.org/305623008/diff/1/skia/ext/paint_simplifier.cc...
skia/ext/paint_simplifier.cc:29:
paint->setFilterLevel(SkPaint::kMedium_FilterLevel);
Do you want to set this to medium, even if the original was kLow or kNone? Seems
like "simplifier" should only change the setting to something lower/simpler...
Your call.

[reveman, 2014-05-29 16:42:27]

PTAL

https://codereview.chromium.org/305623008/diff/1/skia/ext/paint_simplifier.cc
File skia/ext/paint_simplifier.cc (right):

https://codereview.chromium.org/305623008/diff/1/skia/ext/paint_simplifier.cc...
skia/ext/paint_simplifier.cc:29:
paint->setFilterLevel(SkPaint::kMedium_FilterLevel);
On 2014/05/29 12:16:59, reed1 wrote:
> Do you want to set this to medium, even if the original was kLow or kNone?
Seems
> like "simplifier" should only change the setting to something lower/simpler...
> Your call.

Good idea. Done.

[reed1, 2014-05-29 16:54:05]

On 2014/05/29 16:42:27, reveman wrote:
> <span id="abbrex-spnAbbr_11074" class="abbrex-Abbr abbrex-Abbr_PTAL
abbrex-AbbrUnknown abbrex-AbbrUnknownVisible">PTAL</span>
> 
> https://codereview.chromium.org/305623008/diff/1/skia/ext/paint_simplifier.cc
> File skia/ext/paint_simplifier.cc (right):
> 
>
https://codereview.chromium.org/305623008/diff/1/skia/ext/paint_simplifier.cc...
> skia/ext/paint_simplifier.cc:29:
> paint->setFilterLevel(SkPaint::kMedium_FilterLevel);
> On 2014/05/29 12:16:59, reed1 wrote:
> > Do you want to set this to medium, even if the original was kLow or kNone?
> Seems
> > like "simplifier" should only change the setting to something
lower/simpler...
> > Your call.
> 
> Good idea. Done.

lgtm

[enne (OOO), 2014-05-29 17:39:11]

lgtm2

[reveman, 2014-05-29 18:00:30]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-05-29 18:04:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/305623008/20001

[commit-bot: I haz the power, 2014-05-29 20:07:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-29 23:14:40]

Change committed as 273648