Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 308683005: setConfig -> setInfo (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
scroggo, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

setConfig -> setInfo BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14978

Patch Set 1 #

Patch Set 2 : missed one setConfig (release only) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -96 lines) Patch
M dm/DMGpuGMTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMWriteTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 12 chunks +16 lines, -17 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapScaler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkValidationUtils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImagePriv.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/sdl/SkOSWindow_SDL.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/BitmapTest.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PipeTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ShaderOpacityTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
reed1
6 years, 6 months ago (2014-05-29 20:16:32 UTC) #1
robertphillips
lgtm
6 years, 6 months ago (2014-05-29 20:27:24 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-05-29 20:28:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/308683005/1
6 years, 6 months ago (2014-05-29 20:29:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 20:37:22 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-05-29 20:41:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/308683005/10001
6 years, 6 months ago (2014-05-29 20:42:05 UTC) #7
commit-bot: I haz the power
Change committed as 14978
6 years, 6 months ago (2014-05-29 20:48:13 UTC) #8
epoger
A revert of this CL has been created in https://codereview.chromium.org/302053002/ by epoger@google.com. The reason for ...
6 years, 6 months ago (2014-05-29 21:09:07 UTC) #9
scroggo
On 2014/05/29 21:09:07, epoger wrote: > A revert of this CL has been created in ...
6 years, 6 months ago (2014-05-29 22:06:08 UTC) #10
reed1
6 years, 6 months ago (2014-05-30 12:23:09 UTC) #11
Message was sent while issue was closed.
On 2014/05/29 22:06:08, scroggo wrote:
> On 2014/05/29 21:09:07, epoger wrote:
> > A revert of this <span id="abbrex-spnAbbr_22062" class="abbrex-Abbr
abbrex-Abbr_CL abbrex-AbbrUnknown abbrex-AbbrUnknownVisible">CL</span> has been
created in
> > https://codereview.chromium.org/302053002/ by mailto:epoger@google.com.
> > 
> > The reason for reverting is: broke all Windows bots.
> 
> not lgtm. You need to add SK_SUPPORT_LEGACY_SETCONFIG_INFO to
> skia_android_framework to keep the Android framework build green. Perhaps it
> would be helpful to have a separate file like skia_for_chromium_defines.gypi?
> skia_for_android_framework_defines?

1. I fill fix this asap
2. Yes, I think a separate file will make this sort of thing easier to catch.

Powered by Google App Engine
This is Rietveld 408576698