Issue 308563002: Fix polymer_expression binding bug with observable list

Issue 308563002: Fix polymer_expression binding bug with observable list (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 6 months ago

Reviewers:
justinfagnani, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix polymer_expression binding bug with observable list BUG=https://code.google.com/p/dart/issues/detail?id=18749 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=36782

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
M	pkg/polymer_expressions/lib/eval.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/polymer_expressions/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer_expressions/test/bindings_test.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

good catch! LGTM https://codereview.chromium.org/308563002/diff/40001/pkg/polymer_expressions/lib/eval.dart File pkg/polymer_expressions/lib/eval.dart (right): https://codereview.chromium.org/308563002/diff/40001/pkg/polymer_expressions/lib/eval.dart#newcode656 pkg/polymer_expressions/lib/eval.dart:656: if (changes.any((c) => c is ListChangeRecord ...

6 years, 6 months ago (2014-05-29 02:38:10 UTC) #2

Siggi Cherem (dart-lang)

https://codereview.chromium.org/308563002/diff/40001/pkg/polymer_expressions/lib/eval.dart File pkg/polymer_expressions/lib/eval.dart (right): https://codereview.chromium.org/308563002/diff/40001/pkg/polymer_expressions/lib/eval.dart#newcode656 pkg/polymer_expressions/lib/eval.dart:656: if (changes.any((c) => c is ListChangeRecord && c.indexChanged(key))) { ...

6 years, 6 months ago (2014-05-29 03:11:33 UTC) #3

Siggi Cherem (dart-lang)

6 years, 6 months ago (2014-05-29 03:18:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36782 (presubmit successful).

Expand Messages | Collapse Messages