chrome/browser/metrics/metrics_service.h - Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | chrome/browser/metrics/metrics_services_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service.h

diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h

index 9d7cde51a0c378ec9f0ea66f373ce77a6efad84c..7108ca52bddf4c26fa5f5ffd72e783a9ac9a0e27 100644

--- a/chrome/browser/metrics/metrics_service.h

+++ b/chrome/browser/metrics/metrics_service.h

@@ -207,6 +207,7 @@ class MetricsService

bool recording_active() const;

bool reporting_active() const;

+ // TODO(blundell): Move this to ChromeMetricsServiceClient.

void LogPluginLoadingError(const base::FilePath& plugin_path);

// Redundant test to ensure that we are notified of a clean exit.

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | chrome/browser/metrics/metrics_services_manager.h » ('J')