Immediately SetTitle on a new NavigationEntry created via history.pushState

Immediately SetTitle on a new NavigationEntry created via history.pushState

We already have the title available (because we're not throwing away the old
document in the renderer process), and if we don't immediately set the title,
there is a race condition where the title may be updated in the ui before the renderer
process sends a FrameHostMsg_UpdateTitle IPC. In this case, the title will flicker to
the page url and immeidately back to the proper title.

BUG=375455
TEST=NavigationControllerTest.PushStateUpdatesTitle

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274006

[Avi (use Gerrit), 2014-05-30 18:58:24]

LGTM

[Nate Chapin, 2014-05-30 19:02:22]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-05-30 19:04:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/japhet@chromium.org/308143004/1

[nasko, 2014-05-30 19:04:55]

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
File content/browser/frame_host/navigation_controller_impl.cc (right):

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_impl.cc:1061: // sets
was_within_same_page to true. In this case, we alraedy have the
nit: already

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_impl_unittest.cc:4185:
controller().GetVisibleEntry()->SetTitle(title);
GetLastCommittedEntry, since it should already be committed.

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_impl_unittest.cc:4196:
controller().GetVisibleEntry()->GetTitleForDisplay(std::string()));
ditto on GetLastCommittedEntry

[Nate Chapin, 2014-05-30 19:07:14]

The CQ bit was unchecked by japhet@chromium.org

[Nate Chapin, 2014-05-30 19:10:04]

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
File content/browser/frame_host/navigation_controller_impl.cc (right):

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_impl.cc:1061: // sets
was_within_same_page to true. In this case, we alraedy have the
On 2014/05/30 19:04:55, nasko wrote:
> nit: already

Done.

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_impl_unittest.cc:4185:
controller().GetVisibleEntry()->SetTitle(title);
On 2014/05/30 19:04:55, nasko wrote:
> GetLastCommittedEntry, since it should already be committed.

Done.

https://codereview.chromium.org/308143004/diff/1/content/browser/frame_host/n...
content/browser/frame_host/navigation_controller_impl_unittest.cc:4196:
controller().GetVisibleEntry()->GetTitleForDisplay(std::string()));
On 2014/05/30 19:04:55, nasko wrote:
> ditto on GetLastCommittedEntry

Done.

[nasko, 2014-05-30 20:06:52]

lgtm

[Nate Chapin, 2014-05-30 20:07:38]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-05-30 20:10:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/japhet@chromium.org/308143004/10001

[Nate Chapin, 2014-05-30 22:26:35]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-05-30 22:27:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/japhet@chromium.org/308143004/20001

[commit-bot: I haz the power, 2014-05-31 04:07:36]

Change committed as 274006