Immediately SetTitle on a new NavigationEntry created via history.pushState

content/browser/frame_host/navigation_controller_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
@@ skipping 4157 matching lines @@
   controller.ClearAllScreenshots();
   EXPECT_EQ(0, screenshot_manager->GetScreenshotCount());
   for (int i = 0; i < controller.GetEntryCount(); ++i) {
     entry = NavigationEntryImpl::FromNavigationEntry(
         controller.GetEntryAtIndex(i));
     EXPECT_FALSE(entry->screenshot().get()) << "Screenshot " << i
                                             << " not cleared";
   }
 }
 
+TEST_F(NavigationControllerTest, PushStateUpdatesTitle) {
+
+  // Navigate
+  test_rvh()->SendNavigate(1, GURL("http://foo"));
+
+  // Set title
+  base::string16 title(base::ASCIIToUTF16("Title"));
+  controller().GetVisibleEntry()->SetTitle(title);

[nasko, 2014/05/30 19:04:55]

GetLastCommittedEntry, since it should already be committed.

[Nate Chapin, 2014/05/30 19:10:05]

Done.

+
+  // history.pushState() is called.
+  FrameHostMsg_DidCommitProvisionalLoad_Params params;
+  params.page_id = 2;
+  params.url = GURL("http://foo#foo");
+  params.was_within_same_page = true;
+  test_rvh()->SendNavigateWithParams(&params);
+
+  // The title should immediately be visible on the new NavigationEntry.
+  EXPECT_EQ(title,
+            controller().GetVisibleEntry()->GetTitleForDisplay(std::string()));

[nasko, 2014/05/30 19:04:55]

ditto on GetLastCommittedEntry

[Nate Chapin, 2014/05/30 19:10:05]

Done.

+}
+
 // Test that the navigation controller clears its session history when a
 // navigation commits with the clear history list flag set.
 TEST_F(NavigationControllerTest, ClearHistoryList) {
   const GURL url1("http://foo1");
   const GURL url2("http://foo2");
   const GURL url3("http://foo3");
   const GURL url4("http://foo4");
 
   NavigationControllerImpl& controller = controller_impl();
 
@@ skipping 30 matching lines @@
   EXPECT_EQ(1, controller.GetEntryCount());
   EXPECT_EQ(0, controller.GetCurrentEntryIndex());
   EXPECT_EQ(0, controller.GetLastCommittedEntryIndex());
   EXPECT_EQ(-1, controller.GetPendingEntryIndex());
   EXPECT_FALSE(controller.CanGoBack());
   EXPECT_FALSE(controller.CanGoForward());
   EXPECT_EQ(url4, controller.GetVisibleEntry()->GetURL());
 }
 
 }  // namespace content