IndexedDB: Using a mock IndexedDBFactory for unit tests

IndexedDB: IndexedDBDatabase now always requires a factory

Created a new MockIndexedDBFactory for use by unit tests. This obviates the
need to instantiate a real factory (AKA IndexedDBFactoryImpl) in unit tests.
This in turn allows IndexedDBDatabase to be modified to always require an
IndexedDBFactory and removes different paths for test & non-test uses.

Several existing unit tests have been modified to use the new
MockIndexedDBFactory.

BUG=393974
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286644

[jsbell, 2014-07-28 22:26:16]

lgtm

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc
(right):

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc:18: class
MockIDBFactory : public MockIndexedDBFactory {
Can we rename this class to something that distinguishes it from
MockIndexedDBFactory?

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
File content/browser/indexed_db/mock_indexed_db_factory.h (right):

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
content/browser/indexed_db/mock_indexed_db_factory.h:18: // mock template gets
confused and needs typedef to compile.
Should we move the typedef to the base class, for consistency?

[cmumford, 2014-07-28 22:46:35]

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc
(right):

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc:18: class
MockIDBFactory : public MockIndexedDBFactory {
On 2014/07/28 22:26:15, jsbell wrote:
> Can we rename this class to something that distinguishes it from
> MockIndexedDBFactory?

Done.

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
File content/browser/indexed_db/mock_indexed_db_factory.h (right):

https://codereview.chromium.org/308103004/diff/120001/content/browser/indexed...
content/browser/indexed_db/mock_indexed_db_factory.h:18: // mock template gets
confused and needs typedef to compile.
On 2014/07/28 22:26:16, jsbell wrote:
> Should we move the typedef to the base class, for consistency?

Done.

[cmumford, 2014-07-29 15:13:36]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-29 15:15:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/308103004/140001

[commit-bot: I haz the power, 2014-07-29 18:10:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)

[commit-bot: I haz the power, 2014-07-29 20:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 20:20:50]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[cmumford, 2014-07-30 17:27:06]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-30 17:28:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/308103004/160001

[commit-bot: I haz the power, 2014-07-30 21:01:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-31 00:04:04]

Change committed as 286644