IndexedDB: Using a mock IndexedDBFactory for unit tests

content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "base/test/test_simple_task_runner.h"
 #include "content/browser/indexed_db/indexed_db_active_blob_registry.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
-#include "content/browser/indexed_db/indexed_db_factory_impl.h"
 #include "content/browser/indexed_db/indexed_db_fake_backing_store.h"
+#include "content/browser/indexed_db/mock_indexed_db_factory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 namespace {
 
-class MockIDBFactory : public IndexedDBFactoryImpl {
+class MockIDBFactory : public MockIndexedDBFactory {

[jsbell, 2014/07/28 22:26:15]

Can we rename this class to something that distinguishes it from
MockIndexedDBFactory?

[cmumford, 2014/07/28 22:46:35]

Done.

  public:
-  MockIDBFactory() : IndexedDBFactoryImpl(NULL), duplicate_calls_(false) {}
+  MockIDBFactory() : duplicate_calls_(false) {}
 
   virtual void ReportOutstandingBlobs(const GURL& origin_url,
                                       bool blobs_outstanding) OVERRIDE {
     if (blobs_outstanding) {
       if (origins_.count(origin_url)) {
         duplicate_calls_ = true;
       } else {
         origins_.insert(origin_url);
       }
     } else {
       if (!origins_.count(origin_url)) {
         duplicate_calls_ = true;
       } else {
         origins_.erase(origin_url);
       }
     }
   }
 
   bool CheckNoOriginsInUse() const {
     return !duplicate_calls_ && !origins_.size();
   }
+
   bool CheckSingleOriginInUse(const GURL& origin) const {
     return !duplicate_calls_ && origins_.size() == 1 && origins_.count(origin);
   }
 
- protected:
+ private:
   virtual ~MockIDBFactory() {}
 
- private:
   std::set<GURL> origins_;
   bool duplicate_calls_;
 
   DISALLOW_COPY_AND_ASSIGN(MockIDBFactory);
 };
 
 class MockIDBBackingStore : public IndexedDBFakeBackingStore {
  public:
   MockIDBBackingStore(IndexedDBFactory* factory,
                       base::SequencedTaskRunner* task_runner)
@@ skipping 206 matching lines @@
   RunUntilIdle();
 
   // Nothing changes.
   EXPECT_TRUE(factory()->CheckSingleOriginInUse(backing_store()->origin_url()));
   EXPECT_TRUE(backing_store()->CheckUnusedBlobsEmpty());
 }
 
 }  // namespace
 
 }  // namespace content