Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 308073013: Update TSAN suppressions. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com, epoger, jvanverth1
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Update TSAN suppressions. TSAN suppressions need to be on their own line, even free of comments. Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load. Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN has an atomic load that makes the annotation moot. BUG=skia: Committed: https://skia.googlesource.com/skia/+/be7de4fc4229b70b0954f3ea5e3b053dae4c1a9d Committed: https://skia.googlesource.com/skia/+/832cb667498407401a7b508a331a65524736c072

Patch Set 1 #

Patch Set 2 : undo SK_ANNOTATE_UNPROTECTED_READ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/ports/SkBarriers_x86.h View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 6 months ago (2014-06-02 20:14:16 UTC) #1
bungeman-skia
lgtm
6 years, 6 months ago (2014-06-02 20:16:39 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-02 20:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/308073013/1
6 years, 6 months ago (2014-06-02 20:17:33 UTC) #4
commit-bot: I haz the power
Change committed as be7de4fc4229b70b0954f3ea5e3b053dae4c1a9d
6 years, 6 months ago (2014-06-02 20:23:53 UTC) #5
epoger
Broke http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT/builds/657 : from http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT/builds/657/steps/BuildChrome/logs/stdio [20:28:02.838773] ../../third_party/skia/include/core/../../src/ports/SkBarriers_x86.h:11:34: fatal error: SkDynamicAnnotations.h: No such file or directory
6 years, 6 months ago (2014-06-02 20:33:43 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-02 20:36:04 UTC) #7
mtklein
On 2014/06/02 20:33:43, epoger wrote: > Broke > http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT/builds/657 > : > > from > ...
6 years, 6 months ago (2014-06-02 20:36:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/308073013/20001
6 years, 6 months ago (2014-06-02 20:36:42 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 20:46:20 UTC) #10
Message was sent while issue was closed.
Change committed as 832cb667498407401a7b508a331a65524736c072

Powered by Google App Engine
This is Rietveld 408576698