Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: src/ports/SkBarriers_x86.h

Issue 308073013: Update TSAN suppressions. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: undo SK_ANNOTATE_UNPROTECTED_READ Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkBarriers_x86_DEFINED 8 #ifndef SkBarriers_x86_DEFINED
9 #define SkBarriers_x86_DEFINED 9 #define SkBarriers_x86_DEFINED
10 10
11 #include "SkDynamicAnnotations.h"
12
13 #ifdef SK_BUILD_FOR_WIN 11 #ifdef SK_BUILD_FOR_WIN
14 # include <intrin.h> 12 # include <intrin.h>
15 static inline void sk_compiler_barrier() { _ReadWriteBarrier(); } 13 static inline void sk_compiler_barrier() { _ReadWriteBarrier(); }
16 #else 14 #else
17 static inline void sk_compiler_barrier() { asm volatile("" : : : "memory"); } 15 static inline void sk_compiler_barrier() { asm volatile("" : : : "memory"); }
18 #endif 16 #endif
19 17
20 template <typename T> 18 template <typename T>
21 T sk_acquire_load(T* ptr) { 19 T sk_acquire_load(T* ptr) {
22 T val = SK_ANNOTATE_UNPROTECTED_READ(*ptr); 20 T val = *ptr;
23 // On x86, all loads are acquire loads, so we only need a compiler barrier. 21 // On x86, all loads are acquire loads, so we only need a compiler barrier.
24 sk_compiler_barrier(); 22 sk_compiler_barrier();
25 return val; 23 return val;
26 } 24 }
27 25
28 template <typename T> 26 template <typename T>
29 void sk_release_store(T* ptr, T val) { 27 void sk_release_store(T* ptr, T val) {
30 // On x86, all stores are release stores, so we only need a compiler barrier . 28 // On x86, all stores are release stores, so we only need a compiler barrier .
31 sk_compiler_barrier(); 29 sk_compiler_barrier();
32 *ptr = val; 30 *ptr = val;
33 } 31 }
34 32
35 #endif//SkBarriers_x86_DEFINED 33 #endif//SkBarriers_x86_DEFINED
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698