Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 308073005: Oilpan: Replace RefPtrs to Node and its subclasses in core/events/ with Oilpan transition types. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Replace RefPtrs to Node and its subclasses in core/events/ with Oilpan transition types. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M Source/core/events/EventDispatcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/events/EventPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventPath.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/MouseEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MutationEvent.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/events/MutationEvent.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/events/NodeEventContext.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/events/NodeEventContext.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/events/WindowEventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/WindowEventContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tkent
Please take a look.
6 years, 6 months ago (2014-05-30 02:59:18 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-30 03:27:29 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-30 03:47:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308073005/1
6 years, 6 months ago (2014-05-30 03:51:13 UTC) #4
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 6 months ago (2014-05-30 08:00:50 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-30 08:00:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308073005/1
6 years, 6 months ago (2014-05-30 08:01:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 08:59:19 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 09:40:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9573)
6 years, 6 months ago (2014-05-30 09:40:13 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-30 12:29:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308073005/1
6 years, 6 months ago (2014-05-30 12:30:23 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:20:51 UTC) #13
Message was sent while issue was closed.
Change committed as 175126

Powered by Google App Engine
This is Rietveld 408576698