Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/common/extensions/api/notifications.idl

Issue 308053004: Add appIconMask to notification API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed bug caused by updated surrounding code Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/notifications.idl
diff --git a/chrome/common/extensions/api/notifications.idl b/chrome/common/extensions/api/notifications.idl
index da95e62c95a0c86116d435fe282fdccc2045521c..412b2da43d02ddc38ee14dbe7453cb174213bdb7 100644
--- a/chrome/common/extensions/api/notifications.idl
+++ b/chrome/common/extensions/api/notifications.idl
@@ -53,11 +53,20 @@ namespace notifications {
// <em>Required for $(ref:notifications.create)</em> method.
TemplateType? type;
- // Sender's avatar, app icon, or a thumbnail for image notifications.
+ // A URL to the sender's avatar, app icon, or a thumbnail for image
+ // notifications.
not at google - send to devlin 2014/07/21 20:50:15 nit: separate these with a blank line so that they
liyanhou 2014/07/22 00:05:22 Done.
+ // URLs can be data URL, local URL, or blob URL.
not at google - send to devlin 2014/07/21 20:50:15 Let me rephrase this sentence to make sure I under
liyanhou 2014/07/22 00:05:22 Done.
// <em>Required for $(ref:notifications.create)</em> method.
DOMString? iconUrl;
[nodoc] NotificationBitmap? iconBitmap;
+ // A URL to the app icon mask.
+ // URLs can be data URL, local URL, or blob URL.
+ // The app icon mask should be in alpha channel, as only the alpha channel
+ // of the image will be considered.
not at google - send to devlin 2014/07/21 20:50:15 you could say here, A URL to the app icon mask. U
liyanhou 2014/07/22 00:05:22 Done.
+ DOMString? appIconMaskUrl;
+ [nodoc] NotificationBitmap? appIconMaskBitmap;
+
// Title of the notification (e.g. sender name for email).
// <em>Required for $(ref:notifications.create)</em> method.
DOMString? title;
@@ -83,7 +92,8 @@ namespace notifications {
// Secondary notification content.
[nodoc] DOMString? expandedMessage;
- // Image thumbnail for image-type notifications.
+ // A URL to the image thumbnail for image-type notifications.
+ // URLs can be data URL, local URL, or blob URL.
not at google - send to devlin 2014/07/21 20:50:15 likewise
liyanhou 2014/07/22 00:05:22 Done.
DOMString? imageUrl;
[nodoc] NotificationBitmap? imageBitmap;

Powered by Google App Engine
This is Rietveld 408576698