Add appIconMask to notification API

chrome/common/extensions/api/notifications.idl

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.notifications</code> API to create rich notifications
 // using templates and show these notifications to users in the system tray.
 namespace notifications {
   [noinline_doc] enum TemplateType {
     // icon, title, message, expandedMessage, up to two buttons
     basic,
@@ skipping 35 matching lines @@
     DOMString title;
     DOMString? iconUrl;
     [nodoc] NotificationBitmap? iconBitmap;
   };
 
   dictionary NotificationOptions {
     // Which type of notification to display.
     // <em>Required for $(ref:notifications.create)</em> method.
     TemplateType? type;
 
-    // Sender's avatar, app icon, or a thumbnail for image notifications.
+    // A URL to the sender's avatar, app icon, or a thumbnail for image
+    // notifications.

[not at google - send to devlin, 2014/07/21 20:50:15]

nit: separate these with a blank line so that they are detected as separate
paragraphs. That will look better in the generated documentation.

[liyanhou, 2014/07/22 00:05:22]

Done.

+    // URLs can be data URL, local URL, or blob URL.

[not at google - send to devlin, 2014/07/21 20:50:15]

Let me rephrase this sentence to make sure I understand:

This can be a data: URL, blob: URL, or a URL relative to a resource within this
extension's .crx file. It cannot be a URL to a remote resource.

(my main concern is the use of the word "local").

[liyanhou, 2014/07/22 00:05:22]

Done.

     // <em>Required for $(ref:notifications.create)</em> method.
     DOMString? iconUrl;
     [nodoc] NotificationBitmap? iconBitmap;
 
+    // A URL to the app icon mask. 
+    // URLs can be data URL, local URL, or blob URL.
+    // The app icon mask should be in alpha channel, as only the alpha channel
+    // of the image will be considered.

[not at google - send to devlin, 2014/07/21 20:50:15]

you could say here,

A URL to the app icon mask. URLs have the same restrictions as
$(ref:notifications.NotificationOptions.iconUrl iconUrl).

[liyanhou, 2014/07/22 00:05:22]

Done.

+    DOMString? appIconMaskUrl;
+    [nodoc] NotificationBitmap? appIconMaskBitmap;
+
     // Title of the notification (e.g. sender name for email).
     // <em>Required for $(ref:notifications.create)</em> method.
     DOMString? title;
 
     // Main notification content.
     // <em>Required for $(ref:notifications.create)</em> method.
     DOMString? message;
 
     // Alternate notification content with a lower-weight font.
     DOMString? contextMessage;
 
     // Priority ranges from -2 to 2. -2 is lowest priority. 2 is highest. Zero
     // is default.
     long? priority;
 
     // A timestamp associated with the notification, in milliseconds past the
     // epoch (e.g. <code>Date.now() + n</code>).
     double? eventTime;
 
     // Text and icons for up to two notification action buttons.
     NotificationButton[]? buttons;
 
     // Secondary notification content.
     [nodoc] DOMString? expandedMessage;
 
-    // Image thumbnail for image-type notifications.
+    // A URL to the image thumbnail for image-type notifications.
+    // URLs can be data URL, local URL, or blob URL.

[not at google - send to devlin, 2014/07/21 20:50:15]

likewise

[liyanhou, 2014/07/22 00:05:22]

Done.

     DOMString? imageUrl;
     [nodoc] NotificationBitmap? imageBitmap;
 
     // Items for multi-item notifications.
     NotificationItem[]? items;
 
     // Current progress ranges from 0 to 100.
     long? progress;
 
     // Whether to show UI indicating that the app will visibly respond to
@@ skipping 60 matching lines @@
     static void onButtonClicked(DOMString notificationId, long buttonIndex);
 
     // The user changes the permission level.
     static void onPermissionLevelChanged(PermissionLevel level);
 
     // The user clicked on a link for the app's notification settings.
     static void onShowSettings();
   };
 
 };