Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 308043006: [Cast] Clean-up: Merge RtpReceiver+AudioReceiver+VideoReceiver-->FrameReceiver. (Closed)

Created:
6 years, 6 months ago by miu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

[Cast] Clean-up: Merge RtpReceiver+AudioReceiver+VideoReceiver-->FrameReceiver. Creates a new media/cast/receiver directory, and consolidates all code in media/cast/audio_receiver and media/cast/video_receiver, and some modules from media/cast/rtp_receiver into one place. Removed FrameReceiver proxy interface in cast_receiver.h, since there are no special threading/lifecycle concerns. Clients will directly call methods in the CastReceiver interface to request frames on the MAIN thread. BUG=378568 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274464

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Addressed hclam's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+744 lines, -3798 lines) Patch
D media/cast/audio_receiver/audio_decoder.h View 1 chunk +0 lines, -62 lines 0 comments Download
D media/cast/audio_receiver/audio_decoder.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D media/cast/audio_receiver/audio_decoder_unittest.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D media/cast/audio_receiver/audio_receiver.h View 1 chunk +0 lines, -210 lines 0 comments Download
D media/cast/audio_receiver/audio_receiver.cc View 1 chunk +0 lines, -357 lines 0 comments Download
D media/cast/audio_receiver/audio_receiver_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast.gyp View 2 chunks +8 lines, -12 lines 0 comments Download
M media/cast/cast_receiver.h View 1 2 chunks +19 lines, -23 lines 0 comments Download
D media/cast/cast_receiver_impl.h View 1 chunk +0 lines, -55 lines 0 comments Download
D media/cast/cast_receiver_impl.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M media/cast/cast_testing.gypi View 3 chunks +3 lines, -4 lines 0 comments Download
A + media/cast/receiver/audio_decoder.h View 3 chunks +6 lines, -4 lines 0 comments Download
A + media/cast/receiver/audio_decoder.cc View 2 chunks +7 lines, -9 lines 0 comments Download
A + media/cast/receiver/audio_decoder_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
A + media/cast/receiver/cast_receiver_impl.h View 1 2 chunks +85 lines, -18 lines 0 comments Download
A + media/cast/receiver/cast_receiver_impl.cc View 1 4 chunks +166 lines, -314 lines 0 comments Download
A + media/cast/receiver/frame_receiver.h View 1 8 chunks +49 lines, -71 lines 0 comments Download
A + media/cast/receiver/frame_receiver.cc View 1 8 chunks +127 lines, -158 lines 0 comments Download
A + media/cast/receiver/frame_receiver_unittest.cc View 1 10 chunks +223 lines, -70 lines 0 comments Download
A + media/cast/receiver/video_decoder.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + media/cast/receiver/video_decoder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + media/cast/receiver/video_decoder_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M media/cast/rtcp/rtcp.h View 3 chunks +2 lines, -2 lines 0 comments Download
M media/cast/rtcp/rtcp.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M media/cast/rtcp/rtcp_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D media/cast/rtp_receiver/rtp_receiver.h View 1 chunk +0 lines, -53 lines 0 comments Download
D media/cast/rtp_receiver/rtp_receiver.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 13 chunks +13 lines, -16 lines 0 comments Download
M media/cast/test/utility/in_process_receiver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D media/cast/video_receiver/video_decoder.h View 1 chunk +0 lines, -63 lines 0 comments Download
D media/cast/video_receiver/video_decoder.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D media/cast/video_receiver/video_decoder_unittest.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D media/cast/video_receiver/video_receiver.h View 1 chunk +0 lines, -206 lines 0 comments Download
D media/cast/video_receiver/video_receiver.cc View 1 chunk +0 lines, -380 lines 0 comments Download
D media/cast/video_receiver/video_receiver_unittest.cc View 1 chunk +0 lines, -266 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
miu
hubbe or hclam: PTAL. This is *much much* smaller than the delta LOC suggests, for ...
6 years, 6 months ago (2014-05-31 02:24:38 UTC) #1
Alpha Left Google
https://codereview.chromium.org/308043006/diff/20001/media/cast/receiver/cast_receiver_impl.cc File media/cast/receiver/cast_receiver_impl.cc (right): https://codereview.chromium.org/308043006/diff/20001/media/cast/receiver/cast_receiver_impl.cc#newcode80 media/cast/receiver/cast_receiver_impl.cc:80: return base::Bind(&CastReceiverImpl::DispatchReceivedPacket, I think we need a TODO here. ...
6 years, 6 months ago (2014-06-02 20:16:59 UTC) #2
miu
Done and done. LGTY? https://codereview.chromium.org/308043006/diff/20001/media/cast/receiver/cast_receiver_impl.cc File media/cast/receiver/cast_receiver_impl.cc (right): https://codereview.chromium.org/308043006/diff/20001/media/cast/receiver/cast_receiver_impl.cc#newcode80 media/cast/receiver/cast_receiver_impl.cc:80: return base::Bind(&CastReceiverImpl::DispatchReceivedPacket, On 2014/06/02 20:16:59, ...
6 years, 6 months ago (2014-06-02 22:36:07 UTC) #3
Alpha Left Google
lgtm
6 years, 6 months ago (2014-06-02 23:00:32 UTC) #4
miu
The CQ bit was checked by miu@chromium.org
6 years, 6 months ago (2014-06-02 23:28:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/308043006/40001
6 years, 6 months ago (2014-06-02 23:29:14 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 10:45:17 UTC) #7
Message was sent while issue was closed.
Change committed as 274464

Powered by Google App Engine
This is Rietveld 408576698