Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: media/cast/video_receiver/video_receiver_unittest.cc

Issue 308043006: [Cast] Clean-up: Merge RtpReceiver+AudioReceiver+VideoReceiver-->FrameReceiver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed hclam's comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/cast/video_receiver/video_receiver.cc ('k') | media/cast/video_sender/video_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <deque>
6 #include <utility>
7
8 #include "base/bind.h"
9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h"
11 #include "base/test/simple_test_tick_clock.h"
12 #include "media/cast/cast_defines.h"
13 #include "media/cast/cast_environment.h"
14 #include "media/cast/logging/simple_event_subscriber.h"
15 #include "media/cast/rtcp/test_rtcp_packet_builder.h"
16 #include "media/cast/test/fake_single_thread_task_runner.h"
17 #include "media/cast/test/utility/default_config.h"
18 #include "media/cast/transport/pacing/mock_paced_packet_sender.h"
19 #include "media/cast/video_receiver/video_receiver.h"
20 #include "testing/gmock/include/gmock/gmock.h"
21
22 using ::testing::_;
23
24 namespace media {
25 namespace cast {
26
27 namespace {
28
29 const int kPacketSize = 1500;
30 const uint32 kFirstFrameId = 1234;
31 const int kPlayoutDelayMillis = 100;
32
33 class FakeVideoClient {
34 public:
35 FakeVideoClient() : num_called_(0) {}
36 virtual ~FakeVideoClient() {}
37
38 void AddExpectedResult(uint32 expected_frame_id,
39 const base::TimeTicks& expected_playout_time) {
40 expected_results_.push_back(
41 std::make_pair(expected_frame_id, expected_playout_time));
42 }
43
44 void DeliverEncodedVideoFrame(
45 scoped_ptr<transport::EncodedFrame> video_frame) {
46 SCOPED_TRACE(::testing::Message() << "num_called_ is " << num_called_);
47 ASSERT_FALSE(!video_frame)
48 << "If at shutdown: There were unsatisfied requests enqueued.";
49 ASSERT_FALSE(expected_results_.empty());
50 EXPECT_EQ(expected_results_.front().first, video_frame->frame_id);
51 EXPECT_EQ(expected_results_.front().second, video_frame->reference_time);
52 expected_results_.pop_front();
53 ++num_called_;
54 }
55
56 int number_times_called() const { return num_called_; }
57
58 private:
59 std::deque<std::pair<uint32, base::TimeTicks> > expected_results_;
60 int num_called_;
61
62 DISALLOW_COPY_AND_ASSIGN(FakeVideoClient);
63 };
64 } // namespace
65
66 class VideoReceiverTest : public ::testing::Test {
67 protected:
68 VideoReceiverTest() {
69 config_ = GetDefaultVideoReceiverConfig();
70 config_.rtp_max_delay_ms = kPlayoutDelayMillis;
71 // Note: Frame rate must divide 1000 without remainder so the test code
72 // doesn't have to account for rounding errors.
73 config_.max_frame_rate = 25;
74 config_.codec.video = transport::kVp8; // Frame skipping not allowed.
75 testing_clock_ = new base::SimpleTestTickClock();
76 testing_clock_->Advance(base::TimeTicks::Now() - base::TimeTicks());
77 start_time_ = testing_clock_->NowTicks();
78 task_runner_ = new test::FakeSingleThreadTaskRunner(testing_clock_);
79
80 cast_environment_ =
81 new CastEnvironment(scoped_ptr<base::TickClock>(testing_clock_).Pass(),
82 task_runner_,
83 task_runner_,
84 task_runner_);
85
86 receiver_.reset(new VideoReceiver(
87 cast_environment_, config_, &mock_transport_));
88 }
89
90 virtual ~VideoReceiverTest() {}
91
92 virtual void SetUp() {
93 payload_.assign(kPacketSize, 0);
94
95 // Always start with a key frame.
96 rtp_header_.is_key_frame = true;
97 rtp_header_.frame_id = kFirstFrameId;
98 rtp_header_.reference_frame_id = rtp_header_.frame_id;
99 rtp_header_.packet_id = 0;
100 rtp_header_.max_packet_id = 0;
101 }
102
103 void FeedOneFrameIntoReceiver() {
104 receiver_->OnReceivedPayloadData(
105 payload_.data(), payload_.size(), rtp_header_);
106 }
107
108 void FeedLipSyncInfoIntoReceiver() {
109 const base::TimeTicks now = testing_clock_->NowTicks();
110 const int64 rtp_timestamp = (now - start_time_) *
111 kVideoFrequency / base::TimeDelta::FromSeconds(1);
112 CHECK_LE(0, rtp_timestamp);
113 uint32 ntp_seconds;
114 uint32 ntp_fraction;
115 ConvertTimeTicksToNtp(now, &ntp_seconds, &ntp_fraction);
116 TestRtcpPacketBuilder rtcp_packet;
117 rtcp_packet.AddSrWithNtp(config_.incoming_ssrc,
118 ntp_seconds, ntp_fraction,
119 static_cast<uint32>(rtp_timestamp));
120 receiver_->IncomingPacket(rtcp_packet.GetPacket().Pass());
121 }
122
123 FrameReceiverConfig config_;
124 std::vector<uint8> payload_;
125 RtpCastHeader rtp_header_;
126 base::SimpleTestTickClock* testing_clock_; // Owned by CastEnvironment.
127 base::TimeTicks start_time_;
128 transport::MockPacedPacketSender mock_transport_;
129 scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
130 scoped_refptr<CastEnvironment> cast_environment_;
131 FakeVideoClient fake_video_client_;
132
133 // Important for the VideoReceiver to be declared last, since its dependencies
134 // must remain alive until after its destruction.
135 scoped_ptr<VideoReceiver> receiver_;
136
137 DISALLOW_COPY_AND_ASSIGN(VideoReceiverTest);
138 };
139
140 TEST_F(VideoReceiverTest, ReceivesOneFrame) {
141 SimpleEventSubscriber event_subscriber;
142 cast_environment_->Logging()->AddRawEventSubscriber(&event_subscriber);
143
144 EXPECT_CALL(mock_transport_, SendRtcpPacket(_, _))
145 .WillRepeatedly(testing::Return(true));
146
147 FeedLipSyncInfoIntoReceiver();
148 task_runner_->RunTasks();
149
150 // Enqueue a request for a video frame.
151 receiver_->GetEncodedVideoFrame(
152 base::Bind(&FakeVideoClient::DeliverEncodedVideoFrame,
153 base::Unretained(&fake_video_client_)));
154
155 // The request should not be satisfied since no packets have been received.
156 task_runner_->RunTasks();
157 EXPECT_EQ(0, fake_video_client_.number_times_called());
158
159 // Deliver one video frame to the receiver and expect to get one frame back.
160 const base::TimeDelta target_playout_delay =
161 base::TimeDelta::FromMilliseconds(kPlayoutDelayMillis);
162 fake_video_client_.AddExpectedResult(
163 kFirstFrameId, testing_clock_->NowTicks() + target_playout_delay);
164 FeedOneFrameIntoReceiver();
165 task_runner_->RunTasks();
166 EXPECT_EQ(1, fake_video_client_.number_times_called());
167
168 std::vector<FrameEvent> frame_events;
169 event_subscriber.GetFrameEventsAndReset(&frame_events);
170
171 ASSERT_TRUE(!frame_events.empty());
172 EXPECT_EQ(FRAME_ACK_SENT, frame_events.begin()->type);
173 EXPECT_EQ(rtp_header_.frame_id, frame_events.begin()->frame_id);
174 EXPECT_EQ(rtp_header_.rtp_timestamp, frame_events.begin()->rtp_timestamp);
175
176 cast_environment_->Logging()->RemoveRawEventSubscriber(&event_subscriber);
177 }
178
179 TEST_F(VideoReceiverTest, ReceivesFramesRefusingToSkipAny) {
180 EXPECT_CALL(mock_transport_, SendRtcpPacket(_, _))
181 .WillRepeatedly(testing::Return(true));
182
183 const uint32 rtp_advance_per_frame =
184 config_.frequency / config_.max_frame_rate;
185 const base::TimeDelta time_advance_per_frame =
186 base::TimeDelta::FromSeconds(1) / config_.max_frame_rate;
187
188 // Feed and process lip sync in receiver.
189 FeedLipSyncInfoIntoReceiver();
190 task_runner_->RunTasks();
191 const base::TimeTicks first_frame_capture_time = testing_clock_->NowTicks();
192
193 // Enqueue a request for a video frame.
194 const FrameEncodedCallback frame_encoded_callback =
195 base::Bind(&FakeVideoClient::DeliverEncodedVideoFrame,
196 base::Unretained(&fake_video_client_));
197 receiver_->GetEncodedVideoFrame(frame_encoded_callback);
198 task_runner_->RunTasks();
199 EXPECT_EQ(0, fake_video_client_.number_times_called());
200
201 // Receive one video frame and expect to see the first request satisfied.
202 const base::TimeDelta target_playout_delay =
203 base::TimeDelta::FromMilliseconds(kPlayoutDelayMillis);
204 fake_video_client_.AddExpectedResult(
205 kFirstFrameId, first_frame_capture_time + target_playout_delay);
206 rtp_header_.rtp_timestamp = 0;
207 FeedOneFrameIntoReceiver();
208 task_runner_->RunTasks();
209 EXPECT_EQ(1, fake_video_client_.number_times_called());
210
211 // Enqueue a second request for a video frame, but it should not be
212 // fulfilled yet.
213 receiver_->GetEncodedVideoFrame(frame_encoded_callback);
214 task_runner_->RunTasks();
215 EXPECT_EQ(1, fake_video_client_.number_times_called());
216
217 // Receive one video frame out-of-order: Make sure that we are not continuous
218 // and that the RTP timestamp represents a time in the future.
219 rtp_header_.is_key_frame = false;
220 rtp_header_.frame_id = kFirstFrameId + 2; // "Frame 3"
221 rtp_header_.reference_frame_id = kFirstFrameId + 1; // "Frame 2"
222 rtp_header_.rtp_timestamp += 2 * rtp_advance_per_frame;
223 FeedOneFrameIntoReceiver();
224
225 // Frame 2 should not come out at this point in time.
226 task_runner_->RunTasks();
227 EXPECT_EQ(1, fake_video_client_.number_times_called());
228
229 // Enqueue a third request for a video frame.
230 receiver_->GetEncodedVideoFrame(frame_encoded_callback);
231 task_runner_->RunTasks();
232 EXPECT_EQ(1, fake_video_client_.number_times_called());
233
234 // Now, advance time forward such that Frame 2 is now too late for playback.
235 // Regardless, the receiver must NOT emit Frame 3 yet because it is not
236 // allowed to skip frames for VP8.
237 testing_clock_->Advance(2 * time_advance_per_frame + target_playout_delay);
238 task_runner_->RunTasks();
239 EXPECT_EQ(1, fake_video_client_.number_times_called());
240
241 // Now receive Frame 2 and expect both the second and third requests to be
242 // fulfilled immediately.
243 fake_video_client_.AddExpectedResult(
244 kFirstFrameId + 1, // "Frame 2"
245 first_frame_capture_time + 1 * time_advance_per_frame +
246 target_playout_delay);
247 fake_video_client_.AddExpectedResult(
248 kFirstFrameId + 2, // "Frame 3"
249 first_frame_capture_time + 2 * time_advance_per_frame +
250 target_playout_delay);
251 --rtp_header_.frame_id; // "Frame 2"
252 --rtp_header_.reference_frame_id; // "Frame 1"
253 rtp_header_.rtp_timestamp -= rtp_advance_per_frame;
254 FeedOneFrameIntoReceiver();
255 task_runner_->RunTasks();
256 EXPECT_EQ(3, fake_video_client_.number_times_called());
257
258 // Move forward to the playout time of an unreceived Frame 5. Expect no
259 // additional frames were emitted.
260 testing_clock_->Advance(3 * time_advance_per_frame);
261 task_runner_->RunTasks();
262 EXPECT_EQ(3, fake_video_client_.number_times_called());
263 }
264
265 } // namespace cast
266 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/video_receiver/video_receiver.cc ('k') | media/cast/video_sender/video_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698