ui/wm/core/accelerator_delegate.h - Issue 308023002: Add EF_IS_REPEAT flag to KeyEvent to handle repeated accelerators correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/wm/core/accelerator_delegate.h

Issue 308023002: Add EF_IS_REPEAT flag to KeyEvent to handle repeated accelerators correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use ui::EF_IS_REPEAT in test instead Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/wm/core/accelerator_delegate.h

diff --git a/ui/wm/core/accelerator_delegate.h b/ui/wm/core/accelerator_delegate.h

index 966f1679e213432eb3cff3aa78de671617e5fd3a..886d7dba44554b167ccc9e68df49f750bc02c5f2 100644

--- a/ui/wm/core/accelerator_delegate.h

+++ b/ui/wm/core/accelerator_delegate.h

@@ -22,9 +22,6 @@ class AcceleratorDelegate {

KEY_TYPE_OTHER,

};

- // TODO(oshima): Move the repeat detection to AcceleratorFilter.

- virtual void PreProcessAccelerator(const ui::Accelerator& accelerator) = 0;

// Return true if the |accelerator| has been processed.

virtual bool ProcessAccelerator(const ui::KeyEvent& event,

const ui::Accelerator& accelerator,

« no previous file with comments | « ui/views/focus/focus_manager.cc ('k') | ui/wm/core/accelerator_filter.cc » ('j') | no next file with comments »