ui/views/focus/focus_manager.cc - Issue 308023002: Add EF_IS_REPEAT flag to KeyEvent to handle repeated accelerators correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/focus/focus_manager.cc

Issue 308023002: Add EF_IS_REPEAT flag to KeyEvent to handle repeated accelerators correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use ui::EF_IS_REPEAT in test instead Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/focus/focus_manager.cc

diff --git a/ui/views/focus/focus_manager.cc b/ui/views/focus/focus_manager.cc

index b4bbd17cba9081be0fea01481b4bb9e41b0d2bdc..4aa36ad4d6ba60f0ea2510d49249857813869f24 100644

--- a/ui/views/focus/focus_manager.cc

+++ b/ui/views/focus/focus_manager.cc

@@ -68,6 +68,7 @@ bool FocusManager::OnKeyEvent(const ui::KeyEvent& event) {

modifiers |= ui::EF_ALT_DOWN;

ui::Accelerator accelerator(event.key_code(), modifiers);

accelerator.set_type(event.type());

+ accelerator.set_is_repeat(event.IsRepeat());

if (event.type() == ui::ET_KEY_PRESSED) {

// If the focused view wants to process the key event as is, let it be.

« no previous file with comments | « ui/events/event_utils.h ('k') | ui/wm/core/accelerator_delegate.h » ('j') | no next file with comments »