Field layout in class Arguments is incompatible w\ 64-bit archs.

Field layout in class Arguments is incompatible w\ 64-bit archs.

The length_ field must be defined as intptr_t rather than int.  This is
due to the fact that we place native argc/argv values into stack slots
(via SetFrameSlot) and then interpret the slots as a an instance of
Arguments class.

On big endian platforms if length_ is left as int, it is represented
as 32bits of data. These 32bits appear in the wrong half of the 64bit
value when pushed as arguments.

BUG=v8:3366

[danno, 2014-06-03 10:22:40]

lgtm

[danno, 2014-06-03 21:36:37]

Ah. You need to make sure that your CLs are actually based on our svn repository
(yours uses a v8.git base URL, but that's only the Chorium mirror of our SVN
repo), otherwise I can't land this with our standard tools. For that, you will
have to upload a new CL.

I see that the Chromium instructions that we refer to have been changed to use a
git workflow (we will move to that soon, too), but for now we still use svn for
V8. Take a look at this link, it explains how to interact with our SVN server
with the git-cl tools:

https://code.google.com/p/v8/wiki/UsingGit

Note that (confusingly) you will want to use the git svn workflow with SVN (I
find it the most useful).

[Andrew Low, 2014-06-05 16:29:04]

On 2014/06/03 21:36:37, danno wrote:
> Ah. You need to make sure that your CLs are actually based on our svn
repository
> (yours uses a v8.git base URL, but that's only the Chorium mirror of our SVN
> repo), otherwise I can't land this with our standard tools. For that, you will
> have to upload a new CL.
> 
> I see that the Chromium instructions that we refer to have been changed to use
a
> git workflow (we will move to that soon, too), but for now we still use svn
for
> V8. Take a look at this link, it explains how to interact with our SVN server
> with the git-cl tools:
> 
> https://code.google.com/p/v8/wiki/UsingGit
> 
> Note that (confusingly) you will want to use the git svn workflow with SVN (I
> find it the most useful).

I think I did it correctly this time - including creating a google account
associated with my work email. Of course, this caused a new patch set to get
uploaded and a new review link

https://codereview.chromium.org/314123003

Please close this one, and review the new link.