Field layout in class Arguments is incompatible w\ 64-bit archs.

Field layout in class Arguments is incompatible w\ 64-bit archs.

The length_ field must be defined as intptr_t rather than int.  This is
due to the fact that we place native argc/argv values into stack slots
(via SetFrameSlot) and then interpret the slots as a an instance of
Arguments class.

Little endian architectures get 'lucky' that the layout happens to work
with implicit padding.  Big endian is not as lucky.

See Runtime_ArrayConstructor for an example.

Based on
https://github.com/andrewlow/v8/commit/d8c3570f71c0be9914e79139740124bd1ca711a7

BUG=v8:3366
LOG=N
R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21711

[danno, 2014-06-06 08:51:02]

LGTM, I'll land this for you

[danno, 2014-06-06 09:57:16]

Committed patchset #1 manually as r21711 (presubmit successful).

[Andrew Low, 2014-06-06 13:06:49]

On 2014/06/06 09:57:16, danno wrote:
> Committed patchset #1 manually as r21711 (presubmit successful).

Was the patch formatted correctly?
Did this submission meet the standards / process?

I ask because I've got additional patches planned, and if I can improve things
to make it easier, please let me know.

[danno, 2014-06-06 13:10:30]

Yes, it was fine. In the future, if you want to be sure, you can run:

tools/presubmit.py

before uploading your cl if you want to make sure your CL conforms to the style
guide (git-cl upload does this automatically). If there are blatant style
violations, the tool will report them.

FYI: In the near future, we plan on making clang-format the standard for our V8
code formatting, when that happens we'll add formatting compliance to the
presubmit test as well.

[Andrew Low, 2014-06-06 14:14:28]

The most recent version (as of yesterday) of depot_tools is broken in some way
that prevents pre-submit from running. I see some new updates today that may
address that.

I think the issue I was hitting is here
https://code.google.com/p/chromium/issues/detail?id=379065 (the error appears
identical).

However, understood - I'll keep current with depot_tools and ensure presubmit is
clean. We do run tools/presubmit.py for every internal build.