Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 308003011: Fixed flaky EphemeralAppService unit tests (Closed)

Created:
6 years, 6 months ago by tmdiep
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed flaky EphemeralAppService unit tests App launch times can (rarely) be equal, so the comparison should have been less than or equal to. BUG=379132 TEST=unit_tests (EphemeralAppServiceTest.*) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/apps/ephemeral_app_service_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tmdiep
Simple fix for a test that has been flaky for a while. Thanks in advance.
6 years, 6 months ago (2014-06-01 23:07:06 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 6 months ago (2014-06-01 23:26:09 UTC) #2
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 6 months ago (2014-06-01 23:30:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/308003011/1
6 years, 6 months ago (2014-06-01 23:30:52 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 05:41:55 UTC) #5
Message was sent while issue was closed.
Change committed as 274170

Powered by Google App Engine
This is Rietveld 408576698