Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/apps/ephemeral_app_service_unittest.cc

Issue 308003011: Fixed flaky EphemeralAppService unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/ephemeral_app_service_unittest.cc
diff --git a/chrome/browser/apps/ephemeral_app_service_unittest.cc b/chrome/browser/apps/ephemeral_app_service_unittest.cc
index ff0306e909fffe02b7fc3b672d0e80d2677cdec6..6b40cfef5031458649120d3b13b14951e0da1e47 100644
--- a/chrome/browser/apps/ephemeral_app_service_unittest.cc
+++ b/chrome/browser/apps/ephemeral_app_service_unittest.cc
@@ -73,14 +73,14 @@ class EphemeralAppServiceTest : public testing::Test {
if (launch_times.empty())
return;
- // Verify that the removed apps have launch times earlier than all retained
- // apps. We can actually just compare with the first entry in |launch_times|
- // but will make no implementation assumptions.
+ // Verify that the removed apps have launch times earlier than or equal to
+ // all retained apps. We can actually just compare with the first entry in
+ // |launch_times| but will make no implementation assumptions.
for (LaunchTimeAppMap::const_iterator removed = removed_apps.begin();
removed != removed_apps.end(); ++removed) {
for (LaunchTimeAppMap::iterator retained = launch_times.begin();
retained != launch_times.end(); ++retained) {
- EXPECT_TRUE(removed->first < retained->first);
+ EXPECT_LE(removed->first, retained->first);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698