app_list: Drive app integration.

extensions/common/extension.h

Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index 797c906b40dd007382baf2744d94faa1597db3e7..e3af48296105d1042474f0ec3328ccf753f7cd87 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -330,6 +330,8 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
   void set_wants_file_access(bool wants_file_access) {
     wants_file_access_ = wants_file_access;
   }
+  bool is_syncable() const { return is_syncable_; }
+  void set_is_syncable(bool is_syncable) { is_syncable_ = is_syncable; }

[not at google - send to devlin, 2014/06/06 19:15:05]

why did you need to add this here? it should be *only* a property of prefs.

[xiyuan, 2014/06/06 19:24:30]

sync_helper:: IsSyncable and friends make their decisions from Extension only.
They don't have access to ExtensionPrefs.

[not at google - send to devlin, 2014/06/06 19:37:16]

I see. That's... wrong. Sync helper should query prefs, and it doesn't belong in
chrome/common.

[xiyuan, 2014/06/09 20:59:59]

This is removed. The info is now passed via OnExtensionInstalled.

And we have a ShouldSyncApp function that looks at both Extension and Profile,
added the pref checking logic there instead of in sync_helper.

   int creation_flags() const { return creation_flags_; }
   bool from_webstore() const { return (creation_flags_ & FROM_WEBSTORE) != 0; }
   bool from_bookmark() const { return (creation_flags_ & FROM_BOOKMARK) != 0; }
@@ -474,6 +476,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
   // granted it that access).
   bool wants_file_access_;
 
+  // Whether this app is syncable to other devices.
+  bool is_syncable_;
+
   // The flags that were passed to InitFromValue.
   int creation_flags_;