app_list: Drive app integration.

extensions/common/extension.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSION_H_
 #define EXTENSIONS_COMMON_EXTENSION_H_
 
 #include <algorithm>
 #include <iosfwd>
 #include <map>
@@ skipping 312 matching lines @@
   const extensions::Manifest* manifest() const {
     return manifest_.get();
   }
   bool wants_file_access() const { return wants_file_access_; }
   // TODO(rdevlin.cronin): This is needed for ContentScriptsHandler, and should
   // be moved out as part of crbug.com/159265. This should not be used anywhere
   // else.
   void set_wants_file_access(bool wants_file_access) {
     wants_file_access_ = wants_file_access;
   }
+  bool is_syncable() const { return is_syncable_; }
+  void set_is_syncable(bool is_syncable) { is_syncable_ = is_syncable; }

[not at google - send to devlin, 2014/06/06 19:15:05]

why did you need to add this here? it should be *only* a property of prefs.

[xiyuan, 2014/06/06 19:24:30]

sync_helper:: IsSyncable and friends make their decisions from Extension only.
They don't have access to ExtensionPrefs.

[not at google - send to devlin, 2014/06/06 19:37:16]

I see. That's... wrong. Sync helper should query prefs, and it doesn't belong in
chrome/common.

[xiyuan, 2014/06/09 20:59:59]

This is removed. The info is now passed via OnExtensionInstalled.

And we have a ShouldSyncApp function that looks at both Extension and Profile,
added the pref checking logic there instead of in sync_helper.

   int creation_flags() const { return creation_flags_; }
   bool from_webstore() const { return (creation_flags_ & FROM_WEBSTORE) != 0; }
   bool from_bookmark() const { return (creation_flags_ & FROM_BOOKMARK) != 0; }
   bool was_installed_by_default() const {
     return (creation_flags_ & WAS_INSTALLED_BY_DEFAULT) != 0;
   }
   bool was_installed_by_oem() const {
     return (creation_flags_ & WAS_INSTALLED_BY_OEM) != 0;
   }
 
@@ skipping 124 matching lines @@
   bool display_in_launcher_;
 
   // Should this app be shown in the browser New Tab Page.
   bool display_in_new_tab_page_;
 
   // Whether the extension has host permissions or user script patterns that
   // imply access to file:/// scheme URLs (the user may not have actually
   // granted it that access).
   bool wants_file_access_;
 
+  // Whether this app is syncable to other devices.
+  bool is_syncable_;
+
   // The flags that were passed to InitFromValue.
   int creation_flags_;
 
   DISALLOW_COPY_AND_ASSIGN(Extension);
 };
 
 typedef std::vector<scoped_refptr<const Extension> > ExtensionList;
 typedef std::set<ExtensionId> ExtensionIdSet;
 typedef std::vector<ExtensionId> ExtensionIdList;
 
@@ skipping 74 matching lines @@
 
   UpdatedExtensionPermissionsInfo(
       const Extension* extension,
       const PermissionSet* permissions,
       Reason reason);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSION_H_