Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: Source/core/rendering/RenderLayerStackingNode.cpp

Issue 307933010: Restore sanity to RenderLayerStackingNode::shouldBeNormalFlowOnly (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Keep the current semantics Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/layers/layer-compositing-reasons-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerStackingNode.cpp
diff --git a/Source/core/rendering/RenderLayerStackingNode.cpp b/Source/core/rendering/RenderLayerStackingNode.cpp
index a750ce8b08d10930d070635fcb7fe0bce1bb8bb3..a6ad456c69f5c955a97a3415e2faf3f584441177 100644
--- a/Source/core/rendering/RenderLayerStackingNode.cpp
+++ b/Source/core/rendering/RenderLayerStackingNode.cpp
@@ -308,25 +308,7 @@ void RenderLayerStackingNode::updateStackingNodesAfterStyleChange(const RenderSt
bool RenderLayerStackingNode::shouldBeNormalFlowOnly() const
Julien - ping for review 2014/06/06 17:31:25 Let's put a FIXME to rename it to something else (
{
- RenderLayerModelObject* renderer = this->renderer();
-
- const bool couldBeNormalFlow = renderer->hasOverflowClip()
- || renderer->hasReflection()
- || renderer->hasMask()
- || renderer->isCanvas()
- || renderer->isVideo()
- || renderer->isEmbeddedObject()
- || renderer->isRenderIFrame()
- || (renderer->style()->specifiesColumns() && !layer()->isRootLayer());
-
- const bool preventsElementFromBeingNormalFlow = renderer->isPositioned()
- || renderer->hasTransform()
- || renderer->hasClipPath()
- || renderer->hasFilter()
- || renderer->hasBlendMode()
- || layer()->isTransparent();
-
- return couldBeNormalFlow && !preventsElementFromBeingNormalFlow;
+ return !isStackingContext() && !renderer()->isPositioned();
}
void RenderLayerStackingNode::updateIsNormalFlowOnly()
« no previous file with comments | « LayoutTests/inspector/layers/layer-compositing-reasons-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698