Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.h

Issue 307873002: Removed the App Info information from the Create App Shortcuts dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.h
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.h b/chrome/browser/ui/views/create_application_shortcut_view.h
index 7a503258ad6246841876ac43b54e5099c6d2f2f9..374b138acbe9df44c42dd5d446edbfd67d99ac61 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.h
+++ b/chrome/browser/ui/views/create_application_shortcut_view.h
@@ -40,11 +40,21 @@ class Label;
class CreateApplicationShortcutView : public views::DialogDelegateView,
public views::ButtonListener {
public:
+ enum DialogLayout {
+ // URL shortcuts have an info frame at the top with a thumbnail, title and
+ // description.
+ URL_SHORTCUT_LAYOUT,
sky 2014/06/03 17:14:12 Follow naming convention for content, eg DIALOG_LA
sashab 2014/06/11 05:53:13 Done.
+
+ // App shortcuts don't have an info frame, since they are launched from
+ // places where it's clear what app they are from.
+ APP_SHORTCUT_LAYOUT
+ };
+
explicit CreateApplicationShortcutView(Profile* profile);
virtual ~CreateApplicationShortcutView();
// Initialize the controls on the dialog.
- void InitControls();
+ void InitControls(enum DialogLayout dialog_layout);
sky 2014/06/03 17:14:12 no enum here.
sashab 2014/06/11 05:53:13 Done.
// Overridden from views::View:
virtual gfx::Size GetPreferredSize() const OVERRIDE;
@@ -132,9 +142,6 @@ class CreateChromeApplicationShortcutView
virtual bool Cancel() OVERRIDE;
private:
- void OnShortcutInfoLoaded(
- const web_app::ShortcutInfo& shortcut_info);
-
base::Callback<void(bool)> close_callback_;
base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698