Removed the App Info information from the Create App Shortcuts dialog

chrome/browser/ui/views/create_application_shortcut_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 22 matching lines @@
 }
 
 // CreateShortcutViewCommon implements a dialog that asks user where to create
 // the shortcut for given web app.  There are two variants of this dialog:
 // Shortcuts that load a URL in an app-like window, and shortcuts that load
 // a chrome app (the kind you see under "apps" on the new tabs page) in an app
 // window.  These are implemented as subclasses of CreateShortcutViewCommon.
 class CreateApplicationShortcutView : public views::DialogDelegateView,
                                       public views::ButtonListener {
  public:
+  enum DialogLayout {
+    // URL shortcuts have an info frame at the top with a thumbnail, title and
+    // description.
+    URL_SHORTCUT_LAYOUT,

[sky, 2014/06/03 17:14:12]

Follow naming convention for content, eg DIALOG_LAYOUT_URL_SHORTCUT and
DIALOG_LAYOUT_APP_SHORTCUT.

[sashab, 2014/06/11 05:53:13]

Done.

+
+    // App shortcuts don't have an info frame, since they are launched from
+    // places where it's clear what app they are from.
+    APP_SHORTCUT_LAYOUT
+  };
+
   explicit CreateApplicationShortcutView(Profile* profile);
   virtual ~CreateApplicationShortcutView();
 
   // Initialize the controls on the dialog.
-  void InitControls();
+  void InitControls(enum DialogLayout dialog_layout);

[sky, 2014/06/03 17:14:12]

no enum here.

[sashab, 2014/06/11 05:53:13]

Done.

 
   // Overridden from views::View:
   virtual gfx::Size GetPreferredSize() const OVERRIDE;
 
   // Overridden from views::DialogDelegate:
   virtual base::string16 GetDialogButtonLabel(
       ui::DialogButton button) const OVERRIDE;
   virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual base::string16 GetWindowTitle() const OVERRIDE;
   virtual bool Accept() OVERRIDE;
 
   // Overridden from views::ButtonListener:
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
  protected:
   // Adds a new check-box as a child to the view.
   views::Checkbox* AddCheckbox(const base::string16& text, bool checked);
 
   // Profile in which the shortcuts will be created.
   Profile* profile_;
 
   // UI elements on the dialog.
   views::View* app_info_;

[sky, 2014/06/03 17:14:12]

Document this may be NULL.

[sashab, 2014/06/11 05:53:13]

Done.

   views::Label* create_shortcuts_label_;
   views::Checkbox* desktop_check_box_;
   views::Checkbox* menu_check_box_;
   views::Checkbox* quick_launch_check_box_;
 
   // Target shortcut info.
   web_app::ShortcutInfo shortcut_info_;
   // If false, the shortcut will be created in the root level of the Start Menu.
   bool create_in_chrome_apps_subdir_;
 
@@ skipping 42 matching lines @@
  public:
   CreateChromeApplicationShortcutView(
       Profile* profile,
       const extensions::Extension* app,
       const base::Callback<void(bool)>& close_callback);
   virtual ~CreateChromeApplicationShortcutView();
   virtual bool Accept() OVERRIDE;
   virtual bool Cancel() OVERRIDE;
 
  private:
-  void OnShortcutInfoLoaded(
-      const web_app::ShortcutInfo& shortcut_info);
-
   base::Callback<void(bool)> close_callback_;
 
   base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CreateChromeApplicationShortcutView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_