Removed the App Info information from the Create App Shortcuts dialog

chrome/browser/ui/views/create_application_shortcut_view.h

Index: chrome/browser/ui/views/create_application_shortcut_view.h
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.h b/chrome/browser/ui/views/create_application_shortcut_view.h
index 7a503258ad6246841876ac43b54e5099c6d2f2f9..74dad72e54f4fc954c1c720beccb30b94cf9a646 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.h
+++ b/chrome/browser/ui/views/create_application_shortcut_view.h
@@ -43,8 +43,10 @@ class CreateApplicationShortcutView : public views::DialogDelegateView,
   explicit CreateApplicationShortcutView(Profile* profile);
   virtual ~CreateApplicationShortcutView();
 
-  // Initialize the controls on the dialog.
-  void InitControls();
+  // Initialize the controls on the dialog. InitAppInfoControl() must be called
+  // before InitDialog() if it is to be called at all.
+  void InitAppInfoControl();
+  void InitDialog();

[benwells, 2014/05/29 04:49:34]

Did you consider passing a boolean into InitControls / InitDialog?

[sashab, 2014/05/29 05:18:02]

I'm happy either way. InitControls(false) looked a bit weird at first.

Renamed to InitControlsWithAppInfoFrame which looks a bit better.

[benwells, 2014/05/30 01:57:54]

I understand your concern. InitControls(false) is not self documenting at all.
Boolean parameters are often avoided for this reason.

The problem with InitControlsWithAppInfoFrame(false) is that it is still
confusing. When I ignorantly read that function name I think it is going to add
the app info frame (WithAppInfoFrame) and I don't know what the false is for.

The typical solution to this is to create an enum to name the boolean values,
e.g.
CreateApplicationShortcutView::DialogStyle::FOR_WEB_PAGE and ::FOR_APP

Then you call InitControls(DialogStyle::FOR_WEB_PAGE). Or something like that.

[sashab, 2014/05/30 06:51:03]

Nice suggestion. Done.

 
   // Overridden from views::View:
   virtual gfx::Size GetPreferredSize() const OVERRIDE;