Removed the App Info information from the Create App Shortcuts dialog

chrome/browser/ui/views/create_application_shortcut_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 25 matching lines @@
 // the shortcut for given web app.  There are two variants of this dialog:
 // Shortcuts that load a URL in an app-like window, and shortcuts that load
 // a chrome app (the kind you see under "apps" on the new tabs page) in an app
 // window.  These are implemented as subclasses of CreateShortcutViewCommon.
 class CreateApplicationShortcutView : public views::DialogDelegateView,
                                       public views::ButtonListener {
  public:
   explicit CreateApplicationShortcutView(Profile* profile);
   virtual ~CreateApplicationShortcutView();
 
-  // Initialize the controls on the dialog.
-  void InitControls();
+  // Initialize the controls on the dialog. InitAppInfoControl() must be called
+  // before InitDialog() if it is to be called at all.
+  void InitAppInfoControl();
+  void InitDialog();

[benwells, 2014/05/29 04:49:34]

Did you consider passing a boolean into InitControls / InitDialog?

[sashab, 2014/05/29 05:18:02]

I'm happy either way. InitControls(false) looked a bit weird at first.

Renamed to InitControlsWithAppInfoFrame which looks a bit better.

[benwells, 2014/05/30 01:57:54]

I understand your concern. InitControls(false) is not self documenting at all.
Boolean parameters are often avoided for this reason.

The problem with InitControlsWithAppInfoFrame(false) is that it is still
confusing. When I ignorantly read that function name I think it is going to add
the app info frame (WithAppInfoFrame) and I don't know what the false is for.

The typical solution to this is to create an enum to name the boolean values,
e.g.
CreateApplicationShortcutView::DialogStyle::FOR_WEB_PAGE and ::FOR_APP

Then you call InitControls(DialogStyle::FOR_WEB_PAGE). Or something like that.

[sashab, 2014/05/30 06:51:03]

Nice suggestion. Done.

 
   // Overridden from views::View:
   virtual gfx::Size GetPreferredSize() const OVERRIDE;
 
   // Overridden from views::DialogDelegate:
   virtual base::string16 GetDialogButtonLabel(
       ui::DialogButton button) const OVERRIDE;
   virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual base::string16 GetWindowTitle() const OVERRIDE;
@@ skipping 78 matching lines @@
       const web_app::ShortcutInfo& shortcut_info);
 
   base::Callback<void(bool)> close_callback_;
 
   base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CreateChromeApplicationShortcutView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_