Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/metrics/variations/variations_http_header_provider.cc

Issue 307743003: Add more Google domains to the list of domains which should have (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations/variations_http_header_provider.cc
diff --git a/chrome/browser/metrics/variations/variations_http_header_provider.cc b/chrome/browser/metrics/variations/variations_http_header_provider.cc
index 90fde20a0df46a7ae25e8f91559fb7d89f735aa0..600b72b761b9cf7774130b9b32c82c51b9007733 100644
--- a/chrome/browser/metrics/variations/variations_http_header_provider.cc
+++ b/chrome/browser/metrics/variations/variations_http_header_provider.cc
@@ -229,8 +229,19 @@ bool VariationsHttpHeaderProvider::ShouldAppendHeaders(const GURL& url) {
// Some domains don't have international TLD extensions, so testing for them
// is very straight forward.
const std::string host = url.host();
- if (EndsWith(host, ".doubleclick.net", false) ||
+ if (EndsWith(host, ".android.com", false) ||
+ EndsWith(host, ".doubleclick.com", false) ||
+ EndsWith(host, ".doubleclick.net", false) ||
+ EndsWith(host, ".ggpht.com", false) ||
+ EndsWith(host, ".googleadservices.com", false) ||
+ EndsWith(host, ".googleapis.com", false) ||
+ EndsWith(host, ".googleapis.com", false) ||
Alexei Svitkine (slow) 2014/05/29 20:14:38 This seems to be repeated.
Ryan Hamilton 2014/05/29 22:44:27 Done.
EndsWith(host, ".googlesyndication.com", false) ||
+ EndsWith(host, ".googleusercontent.com", false) ||
+ EndsWith(host, ".googlevideo.com", false) ||
Alexei Svitkine (slow) 2014/05/29 20:14:38 This seems to be just a redirect, do we really nee
Ryan Hamilton 2014/05/29 22:44:27 www.googlevideo.com may be a redirect, but there a
+ EndsWith(host, ".gstatic.com", false) ||
+ EndsWith(host, ".youtube.com", false) ||
Alexei Svitkine (slow) 2014/05/29 20:14:38 Youtube is already being checked lower down.
Ryan Hamilton 2014/05/29 22:44:27 Done.
+ EndsWith(host, ".ytimg.com", false) ||
Ryan Hamilton 2014/05/28 22:38:31 If you prefer, we could stick these suffixes into
Alexei Svitkine (slow) 2014/05/29 00:08:54 Yeah, that would be better if we really want that
Ryan Hamilton 2014/05/29 22:44:27 That's the plan, yes.
LowerCaseEqualsASCII(host, "www.googleadservices.com")) {
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698